Paths

Table of Contentst

Differential D87989

Bug 1660378 - part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take `Element&` instead of `nsIContent*` r=m_kato!
ClosedPublic
Actions

Authored by masayuki on Aug 24 2020, 1:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 3 2026, 4:03 AM

	Unknown Object (File)
	Aug 11 2026, 12:50 PM

	Unknown Object (File)
	Jul 8 2026, 12:05 AM

	Unknown Object (File)
	Jul 7 2026, 10:23 PM

	Unknown Object (File)
	Jul 7 2026, 8:18 PM

	Unknown Object (File)
	Jul 7 2026, 7:18 PM

	Unknown Object (File)
	Jul 7 2026, 5:56 PM

	Unknown Object (File)
	Jun 13 2026, 5:03 AM

View All 38 Files

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRALee4715363f70: Bug 1660378 - part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take…

Bugzilla Bug ID

Summary

Although it starts to return error if it causes destroying the editor, but
it should not occur because it modifies new and orphan node and it shouldn't
kick any mutation event listeners. Therefore, this patch makes the callers
handle error as-is rather than ignoring errors except
NS_ERROR_EDITOR_DESTROYED.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

masayuki created this revision.Aug 24 2020, 1:02 AM

Herald added a project: secure-revision. · View Herald TranscriptAug 24 2020, 1:02 AM

Harbormaster completed remote builds in B233664: Diff 330306.Aug 24 2020, 1:02 AM

phab-bot published this revision for review.Aug 24 2020, 1:03 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

masayuki added a child revision: D87990: Bug 1660378 - part 9: Avoid QI for getting `nsStyledElement` pointer r=smaug!.Aug 24 2020, 1:04 AM

masayuki updated this revision to Diff 330323.Aug 24 2020, 3:06 AM

masayuki edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B233678: Diff 330323.Aug 24 2020, 3:06 AM

m_kato accepted this revision.Aug 25 2020, 4:18 AM

This revision is now accepted and ready to land.Aug 25 2020, 4:18 AM

masayuki updated this revision to Diff 331381.Aug 26 2020, 4:47 AM

Harbormaster completed remote builds in B234452: Diff 331381.Aug 26 2020, 4:47 AM

Closed by commit rMOZILLACENTRALee4715363f70: Bug 1660378 - part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take… (authored by masayuki). · Explain WhyAug 26 2020, 6:11 AM

This revision was automatically updated to reflect the committed changes.

masayuki added a commit: rMOZILLACENTRALee4715363f70: Bug 1660378 - part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take….

Revision Contents
Changeset List
Float

Path

Size

editor/

libeditor/

16 lines

HTMLStyleEditor.cpp

171 lines

Diff 331407

editor/libeditor/HTMLEditor.h

Loading...

editor/libeditor/HTMLStyleEditor.cpp

Loading...