Page MenuHomePhabricator
Differential D20950

No bug: Add comment with rationale behind choice of default viewport. r?dbaron
ClosedPublic
Actions

Authored by JanH on Feb 24 2019, 9:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 11, 2:43 PM
Unknown Object (File)
Tue, May 6, 8:10 AM
Unknown Object (File)
Mar 28 2025, 2:46 AM
Unknown Object (File)
Mar 17 2025, 1:52 PM
Unknown Object (File)
Jan 10 2025, 6:35 PM
Unknown Object (File)
Jan 8 2025, 12:21 PM
Unknown Object (File)
Dec 28 2024, 1:25 AM
Unknown Object (File)
Nov 29 2024, 2:03 PM
View All 24 Files
Subscribers
None

Details

Reviewers
dbaron
Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
rMOZILLACENTRAL4f88eb70887a: Bug 1501665 - No bug: Add comment with rationale behind choice of default…
rMOZILLACENTRAL159753062cfa: Bug 1501665 - No bug: Add comment with rationale behind choice of default…
Bugzilla Bug ID
Not provided
Summary

Especially in view of the patches for bug 1501665, which seem to have some-
what misunderstood the reason for the choice of viewport width here.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 47150
Build 57566: arc lint + arc unit

Event Timeline

JanH created this revision.Feb 24 2019, 9:13 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 24 2019, 9:13 PM
Harbormaster completed remote builds in B43509: Diff 66356.Feb 24 2019, 9:13 PM
phab-bot requested review of this revision.Feb 24 2019, 9:14 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
JanH added a child revision: D20951: Bug 1525662 - Part 1: Add test for viewport treatment of plain text documents. r?botond.Feb 24 2019, 9:14 PM
JanH removed Bugzilla Bug ID 1501665.Feb 25 2019, 7:39 AM
JanH updated this revision to Diff 70227.Mar 4 2019, 8:09 PM
JanH added Bugzilla Bug ID 1501665.

Rebase.

JanH removed a child revision: D20951: Bug 1525662 - Part 1: Add test for viewport treatment of plain text documents. r?botond.Mar 4 2019, 8:11 PM
dbaron accepted this revision.Mar 5 2019, 12:15 AM
This revision is now accepted and ready to land.Mar 5 2019, 12:15 AM
JanH added a child revision: D20951: Bug 1525662 - Part 1: Add test for viewport treatment of plain text documents. r?botond.Mar 5 2019, 5:53 PM
JanH updated this revision to Diff 70693.Mar 5 2019, 6:00 PM

Rebase again.

Closed by commit rMOZILLACENTRAL159753062cfa: Bug 1501665 - No bug: Add comment with rationale behind choice of default… (authored by JanH). · Explain WhyMar 5 2019, 7:54 PM
This revision was automatically updated to reflect the committed changes.
JanH reopened this revision.Mar 6 2019, 6:23 PM
This revision is now accepted and ready to land.Mar 6 2019, 6:23 PM
Harbormaster completed remote builds in B47150: Diff 70773.Mar 6 2019, 6:23 PM
JanH removed Bugzilla Bug ID 1501665.Mar 6 2019, 6:59 PM
JanH closed this revision.Mar 12 2019, 8:57 PM

Seems like this landed after all despite the confusion caused by mentioning a different bug in the commit message.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
base/
12 lines91%
Loading...

Diff 70773

View Options

dom/base/Document.cpp

Loading...
Privacy · Cookies · Legal