Bug 1738056 - use fluent to insert channel ref into about dialog instead of hoping nothing gets retranslated, r?mkaply!,#fluent-reviewers!
ClosedPublic
Actions

Authored by Gijs on Mar 10 2023, 6:24 PM.

Details

Reviewers

mkaply
flod

Group Reviewers

Restricted Project

Commits

rMOZILLACENTRAL491f4e9701c8: Bug 1738056 - use fluent to insert channel ref into about dialog instead of…

Bugzilla Bug ID

1738056

Summary

The extant code would fail if the user switched languages while the dialog was
open, as fluent would throw the manually-inserted content away. This patch
properly uses fluent to insert the channel, which also means we don't need to
wait for it to happen after load (because of the previous patch in this
stack), it'll be there immediately.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 516907
Build 613472: arc lint + arc unit

Event Timeline

Gijs created this revision.Mar 10 2023, 6:24 PM

Herald added a project: secure-revision. · View Herald TranscriptMar 10 2023, 6:24 PM

Herald added a subscriber: flod. · View Herald Transcript

Harbormaster completed remote builds in B515921: Diff 691418.Mar 10 2023, 6:24 PM

phab-bot published this revision for review.Mar 10 2023, 6:25 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Code analysis found 2 defects in the diff 691418:

1 defect found by file-whitespace (Mozlint)
1 defect found by py-black (Mozlint)

IMPORTANT: Found 2 issues (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 691418.

Fix lint

Harbormaster completed remote builds in B516012: Diff 691511.Mar 10 2023, 10:23 PM

2 issues closed compared to the previous diff 691418.

If you see a problem in this automated review, please report it here.

flod accepted this revision.Mar 11 2023, 4:18 PM

mkaply accepted this revision.Mar 13 2023, 6:08 PM

This revision is now accepted and ready to land.Mar 13 2023, 6:08 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!