Details
- Reviewers
florian flod - Group Reviewers
Restricted Project - Commits
- rMOZILLACENTRAL23cdfa7dde4b: Bug 1818465 - Add JSOracle+WindowsUtils actors name to about:processes…
rMOZILLACENTRAL0abd5d9c6073: Bug 1818465 - Add JSOracle+WindowsUtils actors name to about:processes… - Bugzilla Bug ID
- 1818465
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable - Build Status
Buildable 511448 Build 607875: arc lint + arc unit
Event Timeline
| toolkit/components/aboutprocesses/content/aboutProcesses.js | ||
|---|---|---|
| 892 | Since we iterate on all member in the test, i can't see a case where we could get tricked | |
| toolkit/locales/en-US/toolkit/about/aboutProcesses.ftl | ||
|---|---|---|
| 133 | Should these two strings be kept in English (and have a comment to explain it)? Out of curiosity: Oracle as in "Oracle DB" or something else? | |
| toolkit/locales/en-US/toolkit/about/aboutProcesses.ftl | ||
|---|---|---|
| 133 | Oracle as in something that answers questions, so not anything tied to the company. | |
| toolkit/locales/en-US/toolkit/about/aboutProcesses.ftl | ||
|---|---|---|
| 133 | And about localization. I really don't know. In that case we should probably expand JS to JavaScript and only localize Oracle. I can see it being "JavaScript Orakel" in Swedish. But it is also really only an internal name of the process that handles JavaScript validation for Opaque Response Blocking. | |
| toolkit/locales/en-US/toolkit/about/aboutProcesses.ftl | ||
|---|---|---|
| 133 | Given this seems to be internal (couldn't find anything with a search on the web), I would add a comment to keep it in English. If space is not a concern, I would also expand JS. # "Oracle" refers to an internal Firefox process and should be kept in English about-processes-utility-actor-js-oracle = JavaScript Oracle about-processes-utility-actor-windows-utils = Windows Utils I assume it's OK if "Utils" gets translated by some as "Utilities". If not, we should add a similar comment. | |
| toolkit/locales/en-US/toolkit/about/aboutProcesses.ftl | ||
|---|---|---|
| 133 | Yeah, JavaScript Oracle as an internal name, only in English, is good for the js oracle. | |