This patch makes the search modifiers a shared component so we can
use this for project search.
Details
- Reviewers
ochameau - Commits
- rMOZILLACENTRALdbfd7f46563e: Bug 1811004 - [devtools] Make the search modifiers a shared component r=ochameau
- Bugzilla Bug ID
- 1811004
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable - Build Status
Buildable 509406 Build 605810: arc lint + arc unit
Event Timeline
Code analysis found 2 defects in the diff 677466:
- 2 defects found by file-whitespace (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 677466.
It looks good codewise, but for some reason there is some issue with the icon, at least on linux:
devtools/client/debugger/src/components/Editor/SearchBar.js | ||
---|---|---|
257–262 | You can simplify the interface between these two components by doing this. |
Code analysis found 2 defects in the diff 680305:
- 2 defects found by file-whitespace (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 680305.
2 issues closed compared to the previous diff 681491.
If you see a problem in this automated review, please report it here.
This looks great, thanks!
devtools/client/debugger/src/components/Editor/SearchBar.js | ||
---|---|---|
259 | To followup on our discussions around cx and the middleware asserting it... We do pass cx for this action: The main reason to pass cx in actions is to have this middleware to stop the action if the context changed: But here... imagine for some weird reason we do navigate while toggling modifiers. It is really unclear this particular action have been affected by https://bugzilla.mozilla.org/show_bug.cgi?id=1535362 ... Also, the middleware assertion is especially useful when things are asynchronous. |