Paths

Table of Contentst

Differential D168685

Bug 1814652 - [devtools] Rename SourceMapLoader#applySourceMap and change its signature. r=ochameau.
ClosedPublic
Actions

Authored by nchevobbe on Feb 2 2023, 3:18 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, May 8, 3:58 PM

	Unknown Object (File)
	Apr 1 2025, 8:00 PM

	Unknown Object (File)
	Mar 31 2025, 4:07 PM

	Unknown Object (File)
	Jan 14 2025, 4:16 AM

	Unknown Object (File)
	Apr 2 2023, 3:32 AM

	Unknown Object (File)
	Mar 9 2023, 7:53 PM

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRALc6fdfdb4eb53: Bug 1814652 - [devtools] Rename SourceMapLoader#applySourceMap and change its…

Bugzilla Bug ID

Summary

Let's make it take an array of ids so we don't need
to create multiple SourceMapConsumer.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 505134
Build 601487: arc lint + arc unit

Event Timeline

nchevobbe created this revision.Feb 2 2023, 3:18 PM

Herald added a project: secure-revision. · View Herald TranscriptFeb 2 2023, 3:18 PM

Harbormaster completed remote builds in B502926: Diff 676545.Feb 2 2023, 3:18 PM

phab-bot published this revision for review.Feb 2 2023, 3:18 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

nchevobbe mentioned this in D168384: Bug 1815452 - [devtools] Simplify mapping structure posted to/from workers. r=bomsy!,ochameau..Feb 3 2023, 11:13 AM

Thanks a lot for this followup cleanup!

devtools/client/shared/source-map-loader/index.js
98–102	nitpick: You might replace `...rest` with `sourceMap`. This would be slightly clearer as we only expect two arguments.
106	suggestion: This might be slightly clearer by also renaming this event to `"source-map-created"`. This would better match SourceMapUrlService's `newSourceMapCreated`.

This revision is now accepted and ready to land.Feb 6 2023, 2:41 PM

rebase and address review comments

Harbormaster completed remote builds in B503699: Diff 677606.Feb 6 2023, 2:57 PM

The analysis task source-test-mozlint-test-manifest failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

rebase and reorganize

Harbormaster completed remote builds in B504839: Diff 678187.Feb 7 2023, 3:02 PM

update bug number

Harbormaster completed remote builds in B504841: Diff 678193.Feb 7 2023, 3:04 PM

Closed by commit rMOZILLACENTRALc6fdfdb4eb53: Bug 1814652 - [devtools] Rename SourceMapLoader#applySourceMap and change its… (authored by nchevobbe). · Explain WhyFeb 7 2023, 4:08 PM

This revision was automatically updated to reflect the committed changes.

nchevobbe added a commit: rMOZILLACENTRALc6fdfdb4eb53: Bug 1814652 - [devtools] Rename SourceMapLoader#applySourceMap and change its….

Harbormaster completed remote builds in B505134: Diff 678228.Feb 13 2023, 9:26 AM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

devtools/

client/

debugger/

src/

actions/

sources/

13 lines

-

-

framework/

source-map-url-service.js

30 lines

95%

Loading...

shared/

source-map-loader/

13 lines

100%

Loading...

12 lines

-

-

4 lines

100%

Loading...

Diff 678228

devtools/client/debugger/src/actions/sources/prettyPrint.js

Loading...

devtools/client/framework/source-map-url-service.js

Loading...

devtools/client/shared/source-map-loader/index.js

Loading...

devtools/client/shared/source-map-loader/source-map.js

Loading...

devtools/client/shared/source-map-loader/worker.js

Loading...