Differential D120301

Bug 1720846 - Fix non-unified build by adding missing #includes - r?florian
ClosedPublic
Actions

Authored by gerald on Jul 20 2021, 7:49 AM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL46ecc01a4a63: Bug 1720846 - Fix non-unified build by adding missing #includes - r=florian

Bugzilla Bug ID

1720846

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 336585
Build 430656: arc lint + arc unit

Event Timeline

gerald created this revision.Jul 20 2021, 7:49 AM

Herald added a project: secure-revision. · View Herald TranscriptJul 20 2021, 7:49 AM

Harbormaster completed remote builds in B336340: Diff 460217.Jul 20 2021, 7:49 AM

gerald added a child revision: D120302: Bug 1720846 - Add mozglue/baseprofiler and tools/profiler to non-unified-compat - r?florian.Jul 20 2021, 7:50 AM

phab-bot published this revision for review.Jul 20 2021, 7:50 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Looks good to me, thanks for fixing this! I wanted to ask for a green try run, but I see you already have one at https://treeherder.mozilla.org/jobs?repo=try&revision=eb80e76c3e468fb77f1cc8da0f895912c90b254b

This revision is now accepted and ready to land.Jul 20 2021, 9:23 AM

Thank you for the review.
I also did a Try run with only the next patch (adding profiler directories to the non-unified-compat file), and it's failing there, proving that the check is really running. And then the next Try you found shows how this patch here fixes these issues.

Closed by commit rMOZILLACENTRAL46ecc01a4a63: Bug 1720846 - Fix non-unified build by adding missing #includes - r=florian (authored by gerald). · Explain WhyJul 20 2021, 9:40 AM

This revision was automatically updated to reflect the committed changes.

gerald added a commit: rMOZILLACENTRAL46ecc01a4a63: Bug 1720846 - Fix non-unified build by adding missing #includes - r=florian.

gerald added a commit: Restricted Diffusion Commit.Jul 21 2021, 9:37 AM

Harbormaster completed remote builds in B336585: Diff 460274.Jul 21 2021, 9:37 AM