Page MenuHomePhabricator

Bug 1716940 - Increase TaskController thread stack size r?bas
ClosedPublic

Authored by jonco on Jun 17 2021, 2:28 PM.
Referenced Files
Unknown Object (File)
Fri, May 2, 1:17 AM
Unknown Object (File)
Apr 4 2025, 11:16 PM
Unknown Object (File)
Dec 28 2024, 5:19 AM
Subscribers

Details

Summary

This increases the stack size used for task controller threads to the size
previously used for JS helper threads. Some parsing use cases can use a lot of
stack.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 330568
Build 424588: arc lint + arc unit

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
jonco edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 17 2021, 2:38 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Code analysis found 2 defects in the diff 452382:

  • 2 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.