Paths

Table of Contentst

Differential D11668

Bug 1497898 - Update jstests.py wpt integration for manifest optimisations,
ClosedPublic
Actions

Authored by jgraham on Nov 12 2018, 6:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 9, 10:16 PM

	Unknown Object (File)
	Apr 7 2025, 7:30 PM

	Unknown Object (File)
	Feb 15 2025, 8:01 AM

	Unknown Object (File)
	Jan 19 2025, 8:11 AM

	Unknown Object (File)
	Dec 22 2024, 2:38 PM

	Unknown Object (File)
	Sep 21 2024, 3:16 PM

	Unknown Object (File)
	Aug 9 2024, 11:57 PM

Subscribers

Details

Reviewers

• bbouvier
Ms2ger

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL6875c54fd481: Bug 1497898 - Update jstests.py wpt integration for manifest optimisations…

Bugzilla Bug ID

Summary

Depends on D10743

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jgraham created this revision.Nov 12 2018, 6:10 PM

Herald added a project: secure-revision. · View Herald TranscriptNov 12 2018, 6:10 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 12 2018, 6:11 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: jandem. · View Herald TranscriptNov 12 2018, 6:11 PM

Harbormaster completed remote builds in B21074: Diff 34518.Nov 12 2018, 6:11 PM

jgraham requested review of this revision.Nov 12 2018, 6:11 PM

Assuming this does the same thing as before, rs=me.

js/src/tests/jstests.py
346	Can you do the code motion in the other changeset, please?

This revision is now accepted and ready to land.Nov 13 2018, 10:55 AM

jgraham updated this revision to Diff 34816.Nov 13 2018, 1:58 PM

jgraham added a reviewer: Ms2ger.Nov 13 2018, 2:10 PM

I implemented the meta_filters feature of ManifestLoader to avoid creating TestharnessTest objects for the thousands of tests in the wpt repository, when only a handful are relevant here. I believe this had a measurable impact on the runtime. (I don't think I still have the data, though.)

You mentioned on IRC that the current code was broken; how so? Does that mean the meta_features API is broken entirely, or just not used correctly here?

This revision now requires changes to proceed.Nov 16 2018, 2:50 PM

jgraham updated this revision to Diff 36182.Nov 16 2018, 3:18 PM

Ms2ger accepted this revision.Nov 16 2018, 5:58 PM

This revision is now accepted and ready to land.Nov 16 2018, 5:58 PM

Closed by commit rMOZILLACENTRAL6875c54fd481: Bug 1497898 - Update jstests.py wpt integration for manifest optimisations… (authored by jgraham). · Explain WhyNov 16 2018, 6:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

js/

src/

tests/

1 line

Diff 36311

js/src/tests/jstests.py

Loading...