Page MenuHomePhabricator

Bug 1680387 - Apply intrinsic image resolution as appropriate in layout/style/dom, and update test expectations. r=tnikkel
ClosedPublic

Authored by emilio on Apr 25 2021, 3:03 PM.
Referenced Files
Unknown Object (File)
Sep 26 2026, 7:58 PM
Unknown Object (File)
Aug 11 2026, 1:03 PM
Unknown Object (File)
Aug 10 2026, 7:07 PM
Unknown Object (File)
Aug 10 2026, 7:01 PM
Unknown Object (File)
Aug 10 2026, 7:00 PM
Unknown Object (File)
Aug 10 2026, 6:58 PM
Unknown Object (File)
Aug 10 2026, 4:08 PM
Unknown Object (File)
Aug 10 2026, 4:08 PM
Subscribers

Details

Summary

This should be mostly straight-forward, since we have code for this
anyways for image-set() and srcset.

The only thing is that we were using floats for resolution, but since
EXIF allows you to scale each axis separately, we now need to pass an
image::Resolution instead.

The main outstanding issue is the spec comment mentioned in the previous
patch, about what happens if you have srcset/image-set and the image
density specified together. For now I've implemented what the
image-set() spec says, but this is subject to change before shipping of
course.

Event Timeline

emilio published this revision for review.Apr 25 2021, 3:04 PM
emilio updated this revision to Diff 431367.
emilio retitled this revision from Bug 1706217 - Apply intrinsic image resolution as appropriate in layout/style/dom, and update test expectations. r=tnikkel to Bug 1680387 - Apply intrinsic image resolution as appropriate in layout/style/dom, and update test expectations. r=tnikkel.
emilio edited the summary of this revision. (Show Details)
emilio changed the Bugzilla Bug ID from 1706217 to 1680387.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Apr 25 2021, 3:05 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 5 defects in the diff 431365:

  • 5 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 5 defects in the diff 431368:

  • 5 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 5 defects in the diff 431367:

  • 5 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 5 defects in the diff 431371:

  • 5 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.May 4 2021, 12:38 AM
This revision is now accepted and ready to land.May 4 2021, 1:30 PM