Page MenuHomePhabricator

Bug 1682030 - Remove NPAPI windowed plugin layer support r=bas!
ClosedPublic

Authored by handyman on Mar 4 2021, 12:24 AM.
Referenced Files
Unknown Object (File)
Sun, May 11, 8:44 PM
Unknown Object (File)
Mon, Apr 14, 12:55 PM
Unknown Object (File)
Sun, Apr 13, 12:55 PM
Unknown Object (File)
Apr 12 2025, 12:49 PM
Unknown Object (File)
Apr 11 2025, 12:49 PM
Unknown Object (File)
Mar 2 2025, 3:43 AM
Unknown Object (File)
Feb 1 2025, 9:27 AM
Unknown Object (File)
Jan 16 2025, 11:46 PM
Subscribers

Details

Summary

Removes stale windowed NPAPI plugin layers support as part of removing all NPAPI support.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 308093
Build 401744: arc lint + arc unit

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 13 defects in the diff 408000:

  • 13 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 408000, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman retitled this revision from Bug 1682030 - Remove NPAPI windowed plugin layer support DONTBUILD r=bas! to Bug 1682030 - Remove NPAPI windowed plugin layer support r=bas!.Mar 4 2021, 6:29 PM
This revision is now accepted and ready to land.Mar 4 2021, 6:33 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

handyman retitled this revision from Bug 1682030 - Remove NPAPI windowed plugin layer support r=bas! to Bug 1682030 - Remove NPAPI windowed plugin layer support r=bas!.
handyman edited the summary of this revision. (Show Details)

Code analysis found 13 defects in the diff 414007:

  • 13 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 414007, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 15 defects in the diff 422357:

  • 13 build errors found by clang-tidy
  • 2 defects found by private static analysis

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 422357, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Apr 6 2021, 12:59 AM

Code analysis found 3 defects in the diff 422927:

  • 1 build error found by clang-tidy
  • 2 defects found by private static analysis

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-mozlint-l10n-conflicts failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-doc-upload failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-mozlint-eslint failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 3 defects in the diff 423038:

  • 1 build error found by clang-tidy
  • 2 defects found by private static analysis

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach static-analysis check --outgoing (C/C++)

You have touched the documentation in diff 423038, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.