Page MenuHomePhabricator

Bug 1502617 - Support ::before / ::after on ::slotted pseudos.
ClosedPublic

Authored by emilio on Oct 27 2018, 6:10 PM.

Details

Reviewers
heycam
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRALb7ed6370bc7d: Bug 1502617 - Support ::before / ::after on ::slotted pseudos. r=heycam
Bugzilla Bug ID
1502617
Summary

See https://github.com/w3c/csswg-drafts/issues/3150 for the issue that would
expand this to all pseudos.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 27 2018, 6:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2018, 6:10 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 27 2018, 6:10 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
emilio requested review of this revision.Oct 27 2018, 6:10 PM
heycam accepted this revision.Oct 29 2018, 3:26 AM
heycam added a subscriber: heycam.
heycam added inline comments.
servo/components/selectors/parser.rs
40

Nit: s/an/a/

1885–1887

Maybe do the matching of result in the top level match, to reduce the indenting a bit?

pseudo_element = match maybe_pseudo {
    None => None,
    Some(SimpleSelectorParseResult::PseudoElement(pseudo)) => ...
    ...
This revision is now accepted and ready to land.Oct 29 2018, 3:26 AM
This revision was automatically updated to reflect the committed changes.