Page MenuHomePhabricator
Differential D9994

Bug 1502617 - Support ::before / ::after on ::slotted pseudos.
ClosedPublic
Actions

Authored by emilio on Oct 27 2018, 6:10 PM.

Details

Reviewers
heycam
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRALb7ed6370bc7d: Bug 1502617 - Support ::before / ::after on ::slotted pseudos. r=heycam
Bugzilla Bug ID
1502617
Summary

See https://github.com/w3c/csswg-drafts/issues/3150 for the issue that would
expand this to all pseudos.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 27 2018, 6:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2018, 6:10 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 27 2018, 6:10 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B17866: Diff 28905.Oct 27 2018, 6:10 PM
emilio requested review of this revision.Oct 27 2018, 6:10 PM
heycam accepted this revision.Oct 29 2018, 3:26 AM
heycam added a subscriber: heycam.
heycam added inline comments.
servo/components/selectors/parser.rs
40

Nit: s/an/a/

1885–1887

Maybe do the matching of result in the top level match, to reduce the indenting a bit?

pseudo_element = match maybe_pseudo {
    None => None,
    Some(SimpleSelectorParseResult::PseudoElement(pseudo)) => ...
    ...
This revision is now accepted and ready to land.Oct 29 2018, 3:26 AM
Closed by commit rMOZILLACENTRALb7ed6370bc7d: Bug 1502617 - Support ::before / ::after on ::slotted pseudos. r=heycam (authored by emilio). · Explain WhyOct 30 2018, 5:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
servo/
components/
selectors/
162 lines
style/
gecko/
8 lines
testing/
web-platform/
meta/
css/
css-scoping/
tests/
css/
css-scoping/
1 line
9 lines

Diff 29387

View Options

servo/components/selectors/parser.rs

Loading...
View Options

servo/components/style/gecko/pseudo_element.rs

Loading...
View Options

testing/web-platform/meta/css/css-scoping/slotted-parsing.html.ini

Loading...
View Options

testing/web-platform/meta/css/css-scoping/slotted-with-pseudo-element.html.ini

Loading...
View Options

testing/web-platform/tests/css/css-scoping/slotted-with-pseudo-element-ref.html

Loading...
View Options

testing/web-platform/tests/css/css-scoping/slotted-with-pseudo-element.html

Loading...
Privacy · Cookies · Legal