Bug 1501492: Enable CSS containment for frontend code. r?dbaron
ClosedPublic
Actions

Authored by dholbert on Oct 26 2018, 9:48 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL28c949ebb06a: Bug 1501492: Enable CSS containment for frontend code. r=dbaron

Bugzilla Bug ID

1501492

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dholbert created this revision.Oct 26 2018, 9:48 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2018, 9:48 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 26 2018, 9:49 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B17815: Diff 28825.Oct 26 2018, 9:49 PM

dholbert requested review of this revision.Oct 26 2018, 9:49 PM

Herald added a subscriber: emilio. · View Herald TranscriptOct 26 2018, 9:49 PM

Could you request review for this after bug 1497414 lands?

In D9963#282942, @dbaron wrote:

Could you request review for this after bug 1497414 lands?

Sure!

Though FWIW, per https://bugzilla.mozilla.org/show_bug.cgi?id=1501492#c3 , I'm not intending to land this until after that other bug has landed. So: if that sways you (i.e. if you're OK preemptively r+'ing this, with the caveat that this land after bug 1497414), feel free to proceed with review whenever you're ready. :)

In D9963#282942, @dbaron wrote:

Could you request review for this after bug 1497414 lands?

OK, bug 1497414 is landing imminently (https://bugzilla.mozilla.org/show_bug.cgi?id=1159042 just landed which was the only thing blocking it; so unless that bounces, I think bug 1497414 is landing shortly)

phabricator doesn't show an obvious way for me to re-request review after a reviewer has "resigned". I'll try removing you and then adding you back - hopefully that works. :)

dholbert added a reviewer: dbaron.Dec 11 2018, 9:31 PM

Sounds good, but we should probably write some sort of documentation for frontend developers around this -- about what benefits are possible, what conditions are required to get those benefits, and what might change in the future.

This revision is now accepted and ready to land.Dec 15 2018, 12:35 AM

In D9963#366194, @dbaron wrote:

Sounds good, but we should probably write some sort of documentation for frontend developers around this -- about what benefits are possible, what conditions are required to get those benefits, and what might change in the future.

Good idea. I wrote up some thoughts / tentative recommendations at https://wiki.mozilla.org/Platform/Layout/CSS_Containment_Best_Practices

Closed by commit rMOZILLACENTRAL28c949ebb06a: Bug 1501492: Enable CSS containment for frontend code. r=dbaron (authored by dholbert). · Explain WhyDec 15 2018, 8:20 AM

This revision was automatically updated to reflect the committed changes.