Page MenuHomePhabricator
Differential D9882

Bug 1502185 - Don't allow auto in grid line names.
ClosedPublic
Actions

Authored by emilio on Oct 26 2018, 12:19 AM.

Details

Reviewers
mats
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL7a6d0f1c6972: Bug 1502185 - Don't allow auto in grid line names. r=mats
Bugzilla Bug ID
1502185
Summary

See https://github.com/w3c/csswg-drafts/issues/2856.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 26 2018, 12:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2018, 12:19 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 26 2018, 12:19 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B17612: Diff 28505.Oct 26 2018, 12:19 AM
emilio requested review of this revision.Oct 26 2018, 12:19 AM
mats accepted this revision.Oct 26 2018, 2:40 AM

Yes, I agree with the CSSWG decision. It's already implicit from the <custom-ident> spec, so it's just an implementation bug really.
Nice catch Eric!

This revision is now accepted and ready to land.Oct 26 2018, 2:40 AM
emilio updated this revision to Diff 28955.Oct 28 2018, 11:25 PM

Missed one place.

Harbormaster completed remote builds in B17901: Diff 28955.Oct 28 2018, 11:25 PM
emilio updated this revision to Diff 28956.Oct 28 2018, 11:26 PM

Update test expectations.

Harbormaster completed remote builds in B17902: Diff 28956.Oct 28 2018, 11:26 PM
Closed by commit rMOZILLACENTRAL7a6d0f1c6972: Bug 1502185 - Don't allow auto in grid line names. r=mats (authored by emilio). · Explain WhyOct 29 2018, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
layout/
style/
test/
2 lines
servo/
components/
style/
values/
generics/
4 lines
specified/
2 lines
testing/
web-platform/
meta/
css/
css-grid/
parsing/

Diff 29008

View Options

layout/style/test/property_database.js

Loading...
View Options

servo/components/style/values/generics/grid.rs

Loading...
View Options

servo/components/style/values/specified/grid.rs

Loading...
View Options

testing/web-platform/meta/css/css-grid/parsing/grid-area-invalid.html.ini

Loading...
Privacy · Cookies · Legal