Bug 1462233 - Simplify invalid custom property handling.
ClosedPublic
Actions

Authored by emilio on Oct 24 2018, 9:19 AM.

Details

Reviewers

xidorn

Group Reviewers

Restricted Project

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL7945ede7e1b8: Bug 1462233 - Simplify invalid custom property handling. r=xidorn

Bugzilla Bug ID

1462233

Summary

It's a bit useless to keep a set of invalid properties if we're going
to use them just to reject lookups into another key. This makes it more
consistent with the cascade / no-references code, and should not change
behavior.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 24 2018, 9:19 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 24 2018, 9:19 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 24 2018, 9:19 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B17139: Diff 27732.Oct 24 2018, 9:19 AM

emilio requested review of this revision.Oct 24 2018, 9:19 AM

I probably need to think a bit more about whether this change is correct.

I guess it's correct... Not sure why I needed an invalid set.

servo/components/style/custom_properties.rs
844–845	There is no invalid set anymore, so `remove it from map`?

This revision is now accepted and ready to land.Oct 24 2018, 11:38 AM

Address comments.

Harbormaster completed remote builds in B19449: Diff 31711.Nov 5 2018, 10:42 AM

emilio marked an inline comment as done.Nov 5 2018, 10:42 AM

Closed by commit rMOZILLACENTRAL7945ede7e1b8: Bug 1462233 - Simplify invalid custom property handling. r=xidorn (authored by emilio). · Explain WhyNov 5 2018, 10:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

servo/

components/

style/

custom_properties.rs

73 lines

Diff 31714

View Options

servo/components/style/custom_properties.rs

Bug 1462233 - Simplify invalid custom property handling.ClosedPublicActions