Details
- Reviewers
ahal - Group Reviewers
perftest-reviewers - Commits
- rMOZILLACENTRAL797a96210c41: Bug 1646421 - flake8 Fix a bunch of actual errors r=ahal
- Bugzilla Bug ID
- 1646421
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| js/src/tests/test262-export.py | ||
|---|---|---|
| 233 | not sure it is what we want here | |
| python/mozbuild/mozbuild/mach_commands.py | ||
| 1484 | not sure what we wanted to do here before? | |
| taskcluster/taskgraph/transforms/job/common.py | ||
| 201 | not sure what we wanted to do here before? | |
| tools/browsertime/mach_commands.py | ||
| 273–274 | this was a funny bug. | |
| js/src/devtools/rootAnalysis/t/testlib.py | ||
|---|---|---|
| 54 | This is now an unused variable. I assume the intention was for it to go in the subprocess.check_call below rather than in the call to format. We should either add it there or remove it (worth following up with the owner of this file). | |
| js/src/vm/jsopcode.py | ||
| 340 | Might be worth flagging the owner of this code in case they meant to include this in the message somewhere. | |
| python/lldbutils/lldbutils/general.py | ||
| 41 | This should probably be except Exception:, unless they intentially meant to catch things like SystemExist and KeyboardInterrupt (which I doubt). | |
| js/src/devtools/rootAnalysis/t/testlib.py | ||
|---|---|---|
| 54 | ||
| js/src/vm/jsopcode.py | ||
| 340 | ||
| python/lldbutils/lldbutils/general.py | ||
| 41 | ok, I will fix that once I received feedback about the other items | |
| python/mozbuild/mozbuild/mach_commands.py | ||
| 1484 | @nalexander rings a bell ? | |
| taskcluster/taskgraph/transforms/job/common.py | ||
| 201 | @tomprince @Callek what do you think? | |
| js/src/vm/jsopcode.py | ||
|---|---|---|
| 340 | thanks. raise Exception('nuses should match stack notation: {op}: '
'{nuses} != {stack_nuses} '
'({stack_uses})'.format(
op=op,
nuses=nuses,
stack_nuses=stack_nuses,
stack_uses=opcode.stack_uses)) | |
| 347 | same here. raise Exception('ndefs should match stack notation: {op}: '
'{ndefs} != {stack_ndefs} '
'({stack_defs})'.format(
op=op,
ndefs=ndefs,
stack_ndefs=stack_ndefs,
stack_defs=opcode.stack_defs)) | |
| python/mozbuild/mozbuild/mach_commands.py | ||
|---|---|---|
| 1484 | Once upon a time this was probably a make target. This looks fine. | |