Page MenuHomePhabricator

Bug 1621390 - Optimize backdrop primitives by collapsing to clear color.
ClosedPublic

Authored by gw on Mar 11 2020, 6:09 AM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Build Status
Buildable 173051
Build 256261: arc lint + arc unit

Event Timeline

gw created this revision.Mar 11 2020, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2020, 6:09 AM
phab-bot requested review of this revision.Mar 11 2020, 6:09 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

There's a couple try failures to sort out tomorrow (I know what is causing them), but this should cover the optimization for backdrop colors.

I think we will just do the backdrop color optimization for now, the other types are very rare and probably not worth the complexity - but we could revisit that if we see them in profiles.

gw added a comment.Mar 11 2020, 6:12 AM

Talos reports a 5% performance win on tscrollx as well.

lsalzman accepted this revision.Mar 11 2020, 8:47 AM
This revision is now accepted and ready to land.Mar 11 2020, 8:47 AM
Bert accepted this revision.Mar 11 2020, 5:18 PM
gw updated this revision to Diff 244696.Mar 15 2020, 10:53 PM
gw updated this revision to Diff 244697.Mar 15 2020, 10:55 PM
gw updated this revision to Diff 244698.Mar 15 2020, 10:59 PM
gw updated this revision to Diff 244730.Mar 16 2020, 3:47 AM