Bug 1579235 - Part 8 - Remove overlay tiles, they can be alpha tiles instead.
ClosedPublic
Actions

Authored by gw on Mar 1 2020, 8:35 PM.

Details

Reviewers

• Bert
nical
kvark

Commits

rMOZILLACENTRAL38b7f4761f50: Bug 1579235 - Part 8 - Remove overlay tiles, they can be alpha tiles instead.

Bugzilla Bug ID

1579235

Summary

A previous patch in this series introduced overlay tiles. However,
now that native surfaces exist for for the opaque and alpha tiles
within a slice, we can remove the overlay tiles array and add
these special tiles to the alpha surface.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gw created this revision.Mar 1 2020, 8:35 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2020, 8:35 PM

Harbormaster completed remote builds in B166665: Diff 236626.Mar 1 2020, 8:35 PM

phab-bot requested review of this revision.Mar 1 2020, 8:35 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

gw added reviewers: • Bert, nical, kvark.Mar 1 2020, 8:36 PM

Try run for this patch seems good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=82f0bfcc3c8aae1fd73b4e9a77c8204f573ec122

gw added a child revision: D64909: Bug 1579235 - Part 9 - Optimize compositor surface overlays..Mar 2 2020, 12:46 AM

nical accepted this revision.Mar 2 2020, 10:07 AM

This revision is now accepted and ready to land.Mar 2 2020, 10:07 AM

Closed by commit rMOZILLACENTRAL38b7f4761f50: Bug 1579235 - Part 8 - Remove overlay tiles, they can be alpha tiles instead. (authored by gw). · Explain WhyMar 2 2020, 11:05 AM

This revision was automatically updated to reflect the committed changes.

gw added a commit: rMOZILLACENTRAL38b7f4761f50: Bug 1579235 - Part 8 - Remove overlay tiles, they can be alpha tiles instead..

That's cool!

gw removed a child revision: D64909: Bug 1579235 - Part 9 - Optimize compositor surface overlays..Mar 2 2020, 9:50 PM

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

src/

composite.rs

50 lines

picture.rs

26 lines

Diff 236880

View Options

gfx/wr/webrender/src/composite.rs