Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I've asked a couple times now why we don't have assert coverage here, and I'd like to hear a plan to address that. This sort of error should be caught immediately in CI. While having up-front validation pass with ANGLE is useful, we need the extra robustness of asserting on these paths so we catch when this fails on CI, regardless of whether we remember to add shaders to our test compile pass.
Comment Actions
We have a follow-up here for catching this on CI:
https://bugzilla.mozilla.org/show_bug.cgi?id=1616159