Page MenuHomePhabricator

Bug 1615614 - Make brush_conic_gradient.glsl compile on GLES.
ClosedPublic

Authored by ntim on Feb 18 2020, 12:18 AM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ntim created this revision.Feb 18 2020, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2020, 12:18 AM
phab-bot requested review of this revision.Feb 18 2020, 12:18 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
jgilbert requested changes to this revision.Feb 18 2020, 1:06 AM

I've asked a couple times now why we don't have assert coverage here, and I'd like to hear a plan to address that. This sort of error should be caught immediately in CI. While having up-front validation pass with ANGLE is useful, we need the extra robustness of asserting on these paths so we catch when this fails on CI, regardless of whether we remember to add shaders to our test compile pass.

This revision now requires changes to proceed.Feb 18 2020, 1:06 AM
jgilbert resigned from this revision.Feb 18 2020, 1:59 AM

We have a follow-up here for catching this on CI:
https://bugzilla.mozilla.org/show_bug.cgi?id=1616159

This revision now requires review to proceed.Feb 18 2020, 1:59 AM
gw accepted this revision.Feb 18 2020, 2:54 AM
This revision is now accepted and ready to land.Feb 18 2020, 2:54 AM