Paths

Table of Contentst

Differential D63115

Bug 1616140 - Rename append_dynamic_properties to append_dynamic_transform_properties. r?gw
ClosedPublic
Actions

Authored by hiro on Feb 17 2020, 11:02 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRAL57b23bc537f2: Bug 1616140 - Rename append_dynamic_properties to…

Bugzilla Bug ID

Summary

It's only for transforms by APZC.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hiro created this revision.Feb 17 2020, 11:02 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2020, 11:02 PM

Harbormaster completed remote builds in B161914: Diff 229877.Feb 17 2020, 11:02 PM

phab-bot requested review of this revision.Feb 17 2020, 11:03 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

I'm unsure about this one - isn't it possible in the future that Gecko might want to use this API to update other properties (such as color properties)?

In D63115#1920686, @gw wrote:

I'm unsure about this one - isn't it possible in the future that Gecko might want to use this API to update other properties (such as color properties)?

For animations driven by CSS (or WebAnimation APIs) we use update_dynamic_properties. append_dynamic_properties is used to _apply_ transform effects based on the CSS transform animations. append means for that purpose.

gw accepted this revision.Feb 17 2020, 11:37 PM

This revision is now accepted and ready to land.Feb 17 2020, 11:37 PM

Thank you!

Closed by commit rMOZILLACENTRAL57b23bc537f2: Bug 1616140 - Rename append_dynamic_properties to… (authored by hiro). · Explain WhyFeb 17 2020, 11:46 PM

This revision was automatically updated to reflect the committed changes.

hiro added a commit: rMOZILLACENTRAL57b23bc537f2: Bug 1616140 - Rename append_dynamic_properties to….

Revision Contents
Changeset List

Path

Size

gfx/

webrender_bindings/

src/

12 lines

wr/

webrender/

src/

render_backend.rs

4 lines

7 lines

webrender_api/

src/

8 lines

Diff 229882

gfx/webrender_bindings/src/bindings.rs

Loading...

gfx/wr/webrender/src/render_backend.rs

Loading...

gfx/wr/webrender/src/scene.rs

Loading...

gfx/wr/webrender_api/src/api.rs

Loading...