Page MenuHomePhabricator

Bug 1529260 - Match shader and CPU glyph rasterization logic for glyphs in local space.
ClosedPublic

Authored by aosmond on Feb 13 2020, 8:33 PM.

Details

Summary

This patch makes the CPU side incorporate the raster scale when
calculating the subpixel position of a glyph. It also makes the shader
side not include the glyph scale factor when recalculating the glyph
position (since it was not known/used when determining the subpixel
position in the first place). This makes the subpixel position stable
when we transition between Screen and Local(raster_scale) spaces.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aosmond created this revision.Feb 13 2020, 8:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2020, 8:33 PM
phab-bot requested review of this revision.Feb 13 2020, 8:33 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
lsalzman accepted this revision.Feb 13 2020, 8:40 PM
This revision is now accepted and ready to land.Feb 13 2020, 8:40 PM