Paths

Table of Contentst

Bug 1579235 - Part 2 - Refactor some of the tile map handling code.
ClosedPublic
Actions

Authored by gw on Feb 13 2020, 5:07 AM.

Details

Reviewers

nical
• Bert

Commits

rMOZILLACENTRAL0c0eb80974b0: Bug 1579235 - Part 2 - Refactor some of the tile map handling code. r=nical,Bert

Bugzilla Bug ID

1579235

Summary

Simplify some of the logic related to handling multiple
compositor surfaces in future, specifically:

Only rebuild the tiles map when the tile rect changes.
Remove need for tiles_to_draw array.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gw created this revision.Feb 13 2020, 5:07 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2020, 5:07 AM

Harbormaster completed remote builds in B160876: Diff 228350.Feb 13 2020, 5:07 AM

phab-bot requested review of this revision.Feb 13 2020, 5:07 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Pending try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfceaedb4b2a9e36feed4413f851e53142acddda

nical accepted this revision.Feb 13 2020, 10:33 AM

This revision is now accepted and ready to land.Feb 13 2020, 10:33 AM

• Bert accepted this revision.Feb 13 2020, 6:08 PM

• Bert added inline comments.

gfx/wr/webrender/src/picture.rs
2393	Minor-- this could be part of the above `if` body?

Closed by commit rMOZILLACENTRAL0c0eb80974b0: Bug 1579235 - Part 2 - Refactor some of the tile map handling code. r=nical,Bert (authored by gw). · Explain WhyFeb 13 2020, 8:31 PM

This revision was automatically updated to reflect the committed changes.

gw added a commit: rMOZILLACENTRAL0c0eb80974b0: Bug 1579235 - Part 2 - Refactor some of the tile map handling code. r=nical,Bert.

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

src/

composite.rs

7 lines

picture.rs

176 lines

Diff 228763

View Options

gfx/wr/webrender/src/composite.rs