Differential D62531

Bug 1595014 - Make dirty rects are invalid when old tiles were dropped
ClosedPublic
Actions

Authored by sotaro on Feb 12 2020, 3:13 AM.

Details

Reviewers

Commits

rMOZILLACENTRAL8e08016b3d0a: Bug 1595014 - Make dirty rects are invalid when old tiles were dropped r=gw

Bugzilla Bug ID

1595014

Summary

composite_simple() calculates combined dirty rect from all tile's dirty rect. But the combined dirty rect becomes invalid when there is an old tile that was dropped. The dropped tile's dirty rect is not counted in composite_simple().

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sotaro created this revision.Feb 12 2020, 3:13 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2020, 3:13 AM

Harbormaster completed remote builds in B160395: Diff 227656.Feb 12 2020, 3:13 AM

phab-bot requested review of this revision.Feb 12 2020, 3:13 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

sotaro retitled this revision from Bug 1595014 - Make dirty rects are invalid when old tiles remain to Bug 1595014 - Make dirty rects are invalid when old tiles were dropped.Feb 12 2020, 4:41 AM

sotaro edited the summary of this revision. (Show Details)

sotaro edited the summary of this revision. (Show Details)Feb 12 2020, 4:43 AM

sotaro edited the summary of this revision. (Show Details)

sotaro edited the summary of this revision. (Show Details)Feb 12 2020, 4:45 AM

sotaro added a reviewer: gw.Feb 12 2020, 4:56 AM

sotaro edited the summary of this revision. (Show Details)

Nice find!

This revision is now accepted and ready to land.Feb 12 2020, 5:27 AM

Closed by commit rMOZILLACENTRAL8e08016b3d0a: Bug 1595014 - Make dirty rects are invalid when old tiles were dropped r=gw (authored by sotaro). · Explain WhyFeb 12 2020, 6:16 AM

This revision was automatically updated to reflect the committed changes.

sotaro added a commit: rMOZILLACENTRAL8e08016b3d0a: Bug 1595014 - Make dirty rects are invalid when old tiles were dropped r=gw.