Differential D61689

Bug 1613375 - Always use reference frame origin offset in snapping transforms.
ClosedPublic
Actions

Authored by aosmond on Feb 5 2020, 2:29 PM.

Details

Reviewers

nical

Commits

rMOZILLACENTRALa2ed78dab7bc: Bug 1613375 - Always use reference frame origin offset in snapping transforms.

Bugzilla Bug ID

1613375

Summary

We incorporate the reference frame origin offset for non-animated
transforms, but forgot for animated transforms. Since the offset itself
is not animated, we should still incorporate it into the snapping
transform.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aosmond created this revision.Feb 5 2020, 2:29 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 2:29 PM

Harbormaster completed remote builds in B158319: Diff 224786.Feb 5 2020, 2:29 PM

phab-bot requested review of this revision.Feb 5 2020, 2:29 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=128876a48d25b50a8919ea8059ddf47763fc0e7c

nical accepted this revision.Feb 5 2020, 3:42 PM

This revision is now accepted and ready to land.Feb 5 2020, 3:42 PM

Closed by commit rMOZILLACENTRALa2ed78dab7bc: Bug 1613375 - Always use reference frame origin offset in snapping transforms. (authored by aosmond). · Explain WhyFeb 5 2020, 3:48 PM

This revision was automatically updated to reflect the committed changes.

aosmond added a commit: rMOZILLACENTRALa2ed78dab7bc: Bug 1613375 - Always use reference frame origin offset in snapping transforms..

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

src/

spatial_node.rs

6 lines

Diff 224819

View Options

gfx/wr/webrender/src/spatial_node.rs

Bug 1613375 - Always use reference frame origin offset in snapping transforms.ClosedPublicActions