Page MenuHomePhabricator

Bug 1611601 - Stop snapping when calculating uv rects on the CPU side.
ClosedPublic

Authored by aosmond on Feb 4 2020, 4:22 PM.

Details

Summary

In bug 1574493, we moved most snapping to scene building and a minority
to frame building. No snapping is done in the shader. However there was
some left over code that still tried to replicate the past behaviour and
this caused wobbling during the rendering. This patch removes the extra
snapping on the CPU side and trusts scene/frame building to do the job.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aosmond created this revision.Feb 4 2020, 4:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2020, 4:22 PM
phab-bot requested review of this revision.Feb 4 2020, 4:23 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=93168f57c33a133ca1e7a2be8f58fd9ac97e8360

The attached revision already has fixes for the Linux/Mac failures, and possibly the Windows when they trickle in. They amount to unexpected passes thus far.

gw accepted this revision.Feb 4 2020, 7:05 PM
This revision is now accepted and ready to land.Feb 4 2020, 7:05 PM