Page MenuHomePhabricator

Bug 1613167 - Enable/Disable rayon in WebRender via pref. r=gw,sotaro
ClosedPublic

Authored by nical on Feb 4 2020, 4:21 PM.

Details

Summary

We need a way to switch it on and off to compare the performance and power usage of various test cases.
The new pref is "webrender.enable-multithreading" and does not require a restart.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Feb 4 2020, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2020, 4:21 PM
phab-bot requested review of this revision.Feb 4 2020, 4:21 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

Code analysis found 3 defects in the diff 224394:

  • 3 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -s -p gfx/layers/ipc/CompositorBridgeParent.cpp gfx/config/gfxVars.h (C/C++)

For your convenience, here is a patch that fixes all the source-test-clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:

Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

nical updated this revision to Diff 224446.Feb 4 2020, 6:10 PM

Revision updated.

Code analysis found 3 defects in the diff 224446:

  • 3 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -s -p gfx/layers/ipc/CompositorBridgeParent.cpp gfx/config/gfxVars.h (C/C++)

For your convenience, here is a patch that fixes all the source-test-clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:

Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

gw accepted this revision.Feb 4 2020, 7:09 PM
This revision is now accepted and ready to land.Feb 4 2020, 7:09 PM
nical updated this revision to Diff 224700.Feb 5 2020, 9:50 AM

Revision updated.

nical edited the summary of this revision. (Show Details)Feb 5 2020, 9:50 AM

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:

Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.