Page MenuHomePhabricator

Bug 1608280 - Part 1 - Add a valid_rect to picture cache and composite tiles.
ClosedPublic

Authored by gw on Jan 31 2020, 7:01 PM.

Details

Summary

This patch introduces a per-tile valid rect. In the initial implementation,
this only uses the bounds of the overall picture cache bounding rect. The
next part of this patch will make use of true per-tile valid regions, to
improve performance where there are holes in a single cache slice.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gw created this revision.Jan 31 2020, 7:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2020, 7:01 PM
phab-bot requested review of this revision.Jan 31 2020, 7:01 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
gw updated this revision to Diff 223716.Jan 31 2020, 7:03 PM
gw updated this revision to Diff 223883.Feb 2 2020, 11:26 PM
gw added a reviewer: sotaro.Feb 3 2020, 4:27 AM
mstange accepted this revision.Feb 3 2020, 11:16 PM

I don't really know this code but this looks reasonable.

This revision is now accepted and ready to land.Feb 3 2020, 11:16 PM