Page MenuHomePhabricator

Bug 1605283 - Improve support for invalidation debugging and testing
ClosedPublic

Authored by Bert on Jan 25 2020, 3:52 AM.

Details

Summary

Third iteration:

Fix broken scrolling (and incorrect positioning of quad tree lines) by
serializing the SpaceMapper(-transform) from take_context, and using it
to transform the primitive rects (instead of the previous translation
based on unclipped.origin);
Note: this is done at visualization time and not at export time to
distinguish actually moving elements from merely-scrolling ones.

Serialize the entire UpdateList, so we get the data (Keys) that's being
added; add it to the overview;

Move the static CSS code into tilecache_base.css; add this and the .js
file to the binary, write them as part of output (instead of manual
copy); clean up CSS a bit;

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Bert created this revision.Jan 25 2020, 3:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2020, 3:52 AM
phab-bot requested review of this revision.Jan 25 2020, 3:52 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
gw accepted this revision.Jan 25 2020, 6:59 AM
gw added inline comments.
gfx/wr/tileview/src/main.rs
41–46

Should we round these instead of cast?

371

Is the & needed here, I'm not sure? An alternative might be html.append_str - probably no better though.

481

Are the spaces here intended? Looks like some of the instructions got removed?

This revision is now accepted and ready to land.Jan 25 2020, 6:59 AM
Bert marked 3 inline comments as done.Jan 28 2020, 8:05 PM
Bert added inline comments.
gfx/wr/tileview/src/main.rs
41–46

Actually now that I think about it, we can just write out floats and let the SVG rasterizer worry about it. No need to round or cast at all.

371

Apparently not, thanks!

481

I was trying to clear out the last status line, but you're right it's kind of pointless.

Bert updated this revision to Diff 222944.Jan 28 2020, 8:05 PM
Bert marked 3 inline comments as done.
nataliaCs reopened this revision.Jan 28 2020, 9:00 PM
This revision is now accepted and ready to land.Jan 28 2020, 9:00 PM