Bug 1608741 - Part 2 - Disable dithering on gradient primitives.
ClosedPublic
Actions

Authored by gw on Jan 20 2020, 10:44 PM.

Details

Reviewers

sotaro
nical
kvark

Commits

rMOZILLACENTRALf758f235dd70: Bug 1608741 - Part 2 - Disable dithering on gradient primitives. r=sotaro,nical

Bugzilla Bug ID

1608741

Summary

There are a number of issues with the current gradient dithering
implementation, that cause many test failures and also fuzziness
rendering when enabling DirectComposition virtual surfaces. In
particular, the dither result is dependent on the offset of the
update rect within a render target.

For now, this patch disables gradient dithering by default. This
gives us:

A heap of new test PASS results (or reduced fuzziness).
Fixes a number of non-deterministic fuzziness bugs with DC.
Improves performance of gradient rendering by a reasonable amount.

We can fix gradient dithering as a follow up, and re-enable if/when
we find content that would benefit from it significantly (we may
be able to improve gradients in other ways than dithering too).

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gw created this revision.Jan 20 2020, 10:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2020, 10:44 PM

Harbormaster completed remote builds in B154981: Diff 220007.Jan 20 2020, 10:44 PM

phab-bot requested review of this revision.Jan 20 2020, 10:44 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Herald added a subscriber: emilio. · View Herald TranscriptJan 20 2020, 10:44 PM

Each one of the test changes is either a new PASS or an _improvement_ in fuzziness (none of them are a regression in fuzziness).

sotaro accepted this revision.Jan 20 2020, 11:19 PM

This revision is now accepted and ready to land.Jan 20 2020, 11:19 PM

gw updated this revision to Diff 220028.Jan 21 2020, 12:24 AM

Harbormaster completed remote builds in B155000: Diff 220028.Jan 21 2020, 12:24 AM

gw updated this revision to Diff 220038.Jan 21 2020, 2:21 AM

Harbormaster completed remote builds in B155006: Diff 220038.Jan 21 2020, 2:21 AM

gw updated this revision to Diff 220043.Jan 21 2020, 4:28 AM

Harbormaster completed remote builds in B155011: Diff 220043.Jan 21 2020, 4:28 AM

gw updated this revision to Diff 220053.Jan 21 2020, 6:35 AM

Harbormaster completed remote builds in B155022: Diff 220053.Jan 21 2020, 6:35 AM

gw updated this revision to Diff 220060.Jan 21 2020, 6:46 AM

Harbormaster completed remote builds in B155028: Diff 220060.Jan 21 2020, 6:46 AM

nical accepted this revision.Jan 21 2020, 11:02 AM

gw updated this revision to Diff 220460.Jan 21 2020, 8:52 PM

Harbormaster completed remote builds in B155305: Diff 220460.Jan 21 2020, 8:52 PM

gw updated this revision to Diff 220550.Jan 21 2020, 10:43 PM

Harbormaster completed remote builds in B155370: Diff 220550.Jan 21 2020, 10:43 PM

I confirmed that there is an intermittent failure in one of the newly enabled tests that also occurs on m-c, so I will mark that test as [FAIL,PASS] for now. Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1610662.

gw updated this revision to Diff 220639.Jan 22 2020, 1:24 AM

Harbormaster completed remote builds in B155427: Diff 220639.Jan 22 2020, 1:24 AM

Closed by commit rMOZILLACENTRALf758f235dd70: Bug 1608741 - Part 2 - Disable dithering on gradient primitives. r=sotaro,nical (authored by gw). · Explain WhyJan 22 2020, 2:45 AM

This revision was automatically updated to reflect the committed changes.

gw added a commit: rMOZILLACENTRALf758f235dd70: Bug 1608741 - Part 2 - Disable dithering on gradient primitives. r=sotaro,nical.