Differential D60151

Bug 1607836 - use SmallVec for render task dependencies. r=gw
ClosedPublic
Actions

Authored by nical on Jan 16 2020, 2:47 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rMOZILLACENTRALdb0378df4c66: Bug 1607836 - use SmallVec for render task dependencies. r=gw

Bugzilla Bug ID

Summary

The majority of render tasks have 0, 1 or 2 dependencies, except for pictures that typically have dozens to hundreds of dependencies. SmallVec with 2 inline elements avoids many tiny heap allocations in pages with a lot of text shadows and other types of render tasks.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Jan 16 2020, 2:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 2:47 PM

Harbormaster completed remote builds in B154027: Diff 218742.Jan 16 2020, 2:47 PM

phab-bot requested review of this revision.Jan 16 2020, 2:47 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

gw accepted this revision.Jan 16 2020, 8:16 PM

gw added inline comments.

gfx/wr/webrender/src/render_task.rs
344	Could we also add the commit message as an inline comment here?

This revision is now accepted and ready to land.Jan 16 2020, 8:16 PM

Revision updated.

Harbormaster completed remote builds in B154126: Diff 218911.Jan 16 2020, 9:18 PM

nical added a child revision: D60182: Bug 1607836 - Preallocate picture task dependency vectors. r=gw.Jan 16 2020, 9:18 PM

Closed by commit rMOZILLACENTRALdb0378df4c66: Bug 1607836 - use SmallVec for render task dependencies. r=gw (authored by nical). · Explain WhyJan 20 2020, 5:49 PM

This revision was automatically updated to reflect the committed changes.

nical added a commit: rMOZILLACENTRALdb0378df4c66: Bug 1607836 - use SmallVec for render task dependencies. r=gw.

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

src/

67 lines

render_task_graph.rs

50 lines

Diff 219912

gfx/wr/webrender/src/render_task.rs

Loading...

gfx/wr/webrender/src/render_task_graph.rs

Loading...