Differential D59675

Bug 1606771 - Fix the middle area of border-image nine-patches. r=jrmuizel,gw
ClosedPublic
Actions

Authored by nical on Jan 13 2020, 11:44 AM.

Tags

None

Subscribers

None

Details

Reviewers

jrmuizel
gw

Commits

rMOZILLACENTRAL834d49acd3c0: Bug 1606771 - Fix the middle area of border-image nine-patches. r=gw

Bugzilla Bug ID

Summary

Unlike the border areas that only nead their own dimensions, the middle area of a border-image determines its repetition parameter based on the size of the borders. A new flag is provided for the brush_image shader to know whether to use the segment's own rect or look at the borders when computing the pattern's size.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Jan 13 2020, 11:44 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2020, 11:44 AM

Harbormaster completed remote builds in B152807: Diff 216968.Jan 13 2020, 11:44 AM

phab-bot requested review of this revision.Jan 13 2020, 11:44 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

gw accepted this revision.Jan 13 2020, 10:47 PM

gw added inline comments.

gfx/wr/webrender/res/brush_image.glsl
111	Let's open a bug for this so we don't forget it.
gfx/wr/webrender/src/gpu_types.rs
416	nit: still spelt incorrectly :)

This revision is now accepted and ready to land.Jan 13 2020, 10:47 PM

Revision updated.

Harbormaster completed remote builds in B153354: Diff 217794.Jan 14 2020, 5:26 PM

nical edited the summary of this revision. (Show Details)Jan 14 2020, 5:26 PM

nical added a child revision: D59899: Bug 1606771 - Fix border-image: round inconsistency caused by floating point precision issues. r=kvark,jrmuizel.

Revision updated.

Harbormaster completed remote builds in B153966: Diff 218673.Jan 16 2020, 11:13 AM

Revision updated.

Harbormaster completed remote builds in B153973: Diff 218683.Jan 16 2020, 12:50 PM

Revision updated.

Harbormaster completed remote builds in B154302: Diff 219118.Jan 17 2020, 10:50 AM

Revision updated.

Harbormaster completed remote builds in B155825: Diff 221262.Jan 22 2020, 11:19 PM

Revision updated.

Harbormaster completed remote builds in B156020: Diff 221548.Jan 23 2020, 2:20 PM

nical added a child revision: D60487: Bug 1606771 - Fall back to blob for border-image-repeat with fill but no edges. r=jrmuizel,gw.Jan 23 2020, 2:22 PM

nical removed a child revision: D59899: Bug 1606771 - Fix border-image: round inconsistency caused by floating point precision issues. r=kvark,jrmuizel.Jan 23 2020, 2:26 PM

Closed by commit rMOZILLACENTRAL834d49acd3c0: Bug 1606771 - Fix the middle area of border-image nine-patches. r=gw (authored by nical). · Explain WhyJan 23 2020, 2:37 PM

This revision was automatically updated to reflect the committed changes.

nical added a commit: rMOZILLACENTRAL834d49acd3c0: Bug 1606771 - Fix the middle area of border-image nine-patches. r=gw.

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

res/

3 lines

brush_image.glsl

30 lines

src/

25 lines

8 lines

Diff 221559

gfx/wr/webrender/res/brush.glsl

Loading...

gfx/wr/webrender/res/brush_image.glsl

Loading...

gfx/wr/webrender/src/border.rs

Loading...

gfx/wr/webrender/src/gpu_types.rs

Loading...