Page MenuHomePhabricator

Bug 1607746 - Part 2: Clean up passing filter mode to shader r?nical
ClosedPublic

Authored by cbrewster on Jan 12 2020, 1:01 AM.

Details

Summary

I removed the old opacity filter path in the brush_blend shader and cleaned up the filter mode
constants in the shader so there are less magic numbers. This should help if/when we move more
filters to their own shaders.

Depends on D59610

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cbrewster created this revision.Jan 12 2020, 1:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2020, 1:01 AM
phab-bot requested review of this revision.Jan 12 2020, 1:01 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
nical accepted this revision.Jan 13 2020, 7:58 AM

Nice!

This revision is now accepted and ready to land.Jan 13 2020, 7:58 AM
lobot added a subscriber: lobot.

Check-in Needed handled, landing queued.