Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles
AbandonedPublic
Actions

Authored by gw on Jan 10 2020, 12:47 AM.

Details

Reviewers

kvark
nical
mstange

Commits

rMOZILLACENTRAL7295ca89e880: Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles…

Bugzilla Bug ID

1608280

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Build Status

Buildable 153040
Build 230531: arc lint + arc unit

Event Timeline

gw created this revision.Jan 10 2020, 12:47 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2020, 12:47 AM

Harbormaster completed remote builds in B152164: Diff 216052.Jan 10 2020, 12:47 AM

phab-bot requested review of this revision.Jan 10 2020, 12:47 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Note that this doesn't pass the valid region rect to the native compositor trait yet, it is only used by the simple (WR) compositing mode. I will implement the native compositor usage of the valid region rect as a follow up.

Try run is pending but looks fine so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=857a416902494607a4dca8673c9a7816a5d4553a&selectedJob=284310706

nical accepted this revision.Jan 10 2020, 8:47 AM

This revision is now accepted and ready to land.Jan 10 2020, 8:47 AM

gw updated this revision to Diff 216856.Jan 12 2020, 9:56 PM

gw retitled this revision from Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles. to Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles.

Harbormaster completed remote builds in B152734: Diff 216856.Jan 12 2020, 9:56 PM

gw updated this revision to Diff 216877.Jan 13 2020, 12:29 AM

Harbormaster completed remote builds in B152752: Diff 216877.Jan 13 2020, 12:29 AM

Most recent try run seems good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=422cdb3ccc14b4d478c3a2e3bbd39ab331a1b0b5

Closed by commit rMOZILLACENTRAL7295ca89e880: Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles… (authored by gw). · Explain WhyJan 13 2020, 2:55 AM

This revision was automatically updated to reflect the committed changes.

gw added a commit: rMOZILLACENTRAL7295ca89e880: Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles….

apavel reopened this revision.Jan 13 2020, 8:43 PM

This revision is now accepted and ready to land.Jan 13 2020, 8:43 PM

apavel added a reverting change: rMOZILLACENTRAL0690f68a8d99: Backed out changeset 7295ca89e880 (bug 1608280) for causing bug 1608912 and bug….Jan 13 2020, 8:43 PM

Harbormaster completed remote builds in B153040: Diff 216885.Jan 16 2020, 7:26 PM

This was backed out for causing some regressions. I've decided to re-implement it with a different design, so this is no longer needed.