Page MenuHomePhabricator
Differential D59115

Bug 1607697 - Address clippy lints about nested branches. r=Gankro
ClosedPublic
Actions

Authored by nical on Jan 8 2020, 1:59 PM.

Details

Reviewers
Gankro
Commits
rMOZILLACENTRAL6158f0a8c5b6: Bug 1607697 - Address clippy lints about nested branches. r=Gankro
rMOZILLACENTRAL6101f5e31e46: Bug 1607697 - Address clippy lints about nested branches. r=Gankro
Bugzilla Bug ID
1607697

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Jan 8 2020, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 1:59 PM
Harbormaster completed remote builds in B151434: Diff 214990.Jan 8 2020, 1:59 PM
phab-bot requested review of this revision.Jan 8 2020, 1:59 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
nical added a child revision: D59116: Bug 1607697 - Pass-by-value clippy lints for some small structures. r=Gankro.Jan 8 2020, 2:00 PM
Gankro accepted this revision.Jan 8 2020, 2:09 PM
Gankro added inline comments.
gfx/wr/webrender/src/scene_builder_thread.rs
679

still would prefer the version where this if-let wraps an inner if

This revision is now accepted and ready to land.Jan 8 2020, 2:09 PM
nical updated this revision to Diff 215050.Jan 8 2020, 3:40 PM

Revision updated.

Harbormaster completed remote builds in B151487: Diff 215050.Jan 8 2020, 3:40 PM
nical edited the summary of this revision. (Show Details)Jan 8 2020, 3:40 PM
Closed by commit rMOZILLACENTRAL6101f5e31e46: Bug 1607697 - Address clippy lints about nested branches. r=Gankro (authored by nical). · Explain WhyJan 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.
nical added a commit: rMOZILLACENTRAL6101f5e31e46: Bug 1607697 - Address clippy lints about nested branches. r=Gankro.
dluca reopened this revision.Jan 8 2020, 4:10 PM
This revision is now accepted and ready to land.Jan 8 2020, 4:10 PM
dluca added a reverting change: rMOZILLACENTRALc2dd65b196d3: Backed out 8 changesets (bug 1607697) for Build bustages. CLOSED TREE.Jan 8 2020, 4:10 PM
nical updated this revision to Diff 216187.Jan 10 2020, 10:12 AM

Revision updated.

Harbormaster completed remote builds in B152272: Diff 216187.Jan 10 2020, 10:12 AM
Closed by commit rMOZILLACENTRAL6158f0a8c5b6: Bug 1607697 - Address clippy lints about nested branches. r=Gankro (authored by nical). · Explain WhyJan 10 2020, 10:24 AM
This revision was automatically updated to reflect the committed changes.
nical added a commit: rMOZILLACENTRAL6158f0a8c5b6: Bug 1607697 - Address clippy lints about nested branches. r=Gankro.

Revision Contents
Changeset List

PathSize
gfx/
wr/
webrender/
src/
41 lines
prim_store/
14 lines
9 lines
2 lines
18 lines
6 lines

Diff 216198

View Options

gfx/wr/webrender/src/picture.rs

Loading...
View Options

gfx/wr/webrender/src/prim_store/mod.rs

Loading...
View Options

gfx/wr/webrender/src/render_backend.rs

Loading...
View Options

gfx/wr/webrender/src/renderer.rs

Loading...
View Options

gfx/wr/webrender/src/resource_cache.rs

Loading...
View Options

gfx/wr/webrender/src/scene_builder_thread.rs

Loading...
Privacy · Cookies · Legal