Page MenuHomePhabricator
Differential D59114

Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy lints. r=Gankro
ClosedPublic
Actions

Authored by nical on Jan 8 2020, 1:59 PM.

Details

Reviewers
Gankro
Commits
rMOZILLACENTRAL966cc16c3feb: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy…
rMOZILLACENTRALd70cc2bb33f6: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy…
Bugzilla Bug ID
1607697
Summary

I don't think it makes much of a difference but clippy is quite vocal about it.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Jan 8 2020, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 1:59 PM
Harbormaster completed remote builds in B151433: Diff 214989.Jan 8 2020, 1:59 PM
phab-bot requested review of this revision.Jan 8 2020, 1:59 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
nical added a child revision: D59115: Bug 1607697 - Address clippy lints about nested branches. r=Gankro.Jan 8 2020, 1:59 PM
Gankro accepted this revision.Jan 8 2020, 2:06 PM
This revision is now accepted and ready to land.Jan 8 2020, 2:06 PM
nical updated this revision to Diff 215049.Jan 8 2020, 3:40 PM

Revision updated.

Harbormaster completed remote builds in B151486: Diff 215049.Jan 8 2020, 3:40 PM
nical edited the summary of this revision. (Show Details)Jan 8 2020, 3:40 PM
Closed by commit rMOZILLACENTRALd70cc2bb33f6: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy… (authored by nical). · Explain WhyJan 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.
nical added a commit: rMOZILLACENTRALd70cc2bb33f6: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy….
dluca reopened this revision.Jan 8 2020, 4:10 PM
This revision is now accepted and ready to land.Jan 8 2020, 4:10 PM
dluca added a reverting change: rMOZILLACENTRALc2dd65b196d3: Backed out 8 changesets (bug 1607697) for Build bustages. CLOSED TREE.Jan 8 2020, 4:10 PM
nical updated this revision to Diff 216186.Jan 10 2020, 10:12 AM

Revision updated.

Harbormaster completed remote builds in B152271: Diff 216186.Jan 10 2020, 10:12 AM
Closed by commit rMOZILLACENTRAL966cc16c3feb: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy… (authored by nical). · Explain WhyJan 10 2020, 10:24 AM
This revision was automatically updated to reflect the committed changes.
nical added a commit: rMOZILLACENTRAL966cc16c3feb: Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy….

Revision Contents
Changeset List

PathSize
gfx/
wr/
webrender/
src/
2 lines
3 lines
8 lines
8 lines
4 lines
2 lines

Diff 216197

View Options

gfx/wr/webrender/src/image.rs

Loading...
View Options

gfx/wr/webrender/src/lib.rs

Loading...
View Options

gfx/wr/webrender/src/picture.rs

Loading...
View Options

gfx/wr/webrender/src/render_task.rs

Loading...
View Options

gfx/wr/webrender/src/resource_cache.rs

Loading...
View Options

gfx/wr/webrender/src/scene_building.rs

Loading...
Privacy · Cookies · Legal