Page MenuHomePhabricator

Bug 1606685 - Support empty tiles within compositor surfaces.
ClosedPublic

Authored by gw on Jan 7 2020, 11:46 PM.

Details

Summary

This adds support for holes within virtual surfaces. On platforms
that don't use virtual surfaces, this just works by destroying
the tile that is empty so it never gets composited.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gw created this revision.Jan 7 2020, 11:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2020, 11:46 PM
phab-bot requested review of this revision.Jan 7 2020, 11:47 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

This implements the first part - supporting empty tiles (holes) in surfaces. I'm working on the second part (per-tile clip rects to reduce pixel count further) as a follow up.

sotaro accepted this revision.Jan 8 2020, 2:33 AM
This revision is now accepted and ready to land.Jan 8 2020, 2:33 AM
sotaro added a comment.Jan 8 2020, 2:54 AM

Since applying the patch, I saw a white rectangle during scrolling a page or Tab switching. I wonder if the problem is related to the patch. I do not know a specific STR to reproduce it reliably yet.

gw added a comment.Jan 8 2020, 3:06 AM

Since applying the patch, I saw a white rectangle during scrolling a page or Tab switching. I wonder if the problem is related to the patch. I do not know a specific STR to reproduce it reliably yet.

OK, I won't merge this for now.

sotaro added a comment.Jan 8 2020, 3:46 AM

https://www.yahoo.com/ was easier to reproduce the problem for me. I confirmed it on 2 Win10 PCs. Without the patch, I did not see the problem.
STR

When the problem did not happen at [4], the repeat [3] and [4].

gw added a comment.Jan 8 2020, 4:27 AM

https://www.yahoo.com/ was easier to reproduce the problem for me. I confirmed it on 2 Win10 PCs. Without the patch, I did not see the problem.
STR

When the problem did not happen at [4], the repeat [3] and [4].

I can repro this locally - I will investigate today / tomorrow. Thanks for the repro!

gw updated this revision to Diff 214806.Jan 8 2020, 4:42 AM
gw added a comment.Jan 8 2020, 4:43 AM

Updated with a fix for a typo in the UpdateAllocatedRect method. Seems to fix the problem for me.

sotaro added a comment.Jan 8 2020, 4:57 AM

Updated patch addressed the problem also for me!