Bug 1607419 - Avoid option.expect(&format in hot code. r=kvark
ClosedPublic
Actions

Authored by nical on Jan 7 2020, 10:49 AM.

Details

Reviewers

kvark
jrmuizel

Commits

rMOZILLACENTRAL031a2ee21fa6: Bug 1607419 - Avoid option.expect(&format in hot code. r=jrmuizel

Bugzilla Bug ID

1607419

Summary

Easy to miss that the slow formatting code is run unconditionally.
The remaining instances are in recording and startup code.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Jan 7 2020, 10:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2020, 10:49 AM

Harbormaster completed remote builds in B150940: Diff 214265.Jan 7 2020, 10:49 AM

phab-bot requested review of this revision.Jan 7 2020, 10:49 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

jrmuizel accepted this revision.Jan 7 2020, 3:40 PM

This revision is now accepted and ready to land.Jan 7 2020, 3:40 PM

Closed by commit rMOZILLACENTRAL031a2ee21fa6: Bug 1607419 - Avoid option.expect(&format in hot code. r=jrmuizel (authored by nical). · Explain WhyJan 8 2020, 8:01 AM

This revision was automatically updated to reflect the committed changes.

nical added a commit: rMOZILLACENTRAL031a2ee21fa6: Bug 1607419 - Avoid option.expect(&format in hot code. r=jrmuizel.

Revision Contents
Changeset List

Path

Size

gfx/

wr/

webrender/

src/

prim_store/

mod.rs

2 lines

renderer.rs

2 lines

Diff 214833

View Options

gfx/wr/webrender/src/prim_store/mod.rs