Page MenuHomePhabricator

Bug 1604625 - Add nightly config value to enable GL error checking.
ClosedPublic

Authored by gw on Dec 17 2019, 9:16 PM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Build Status
Buildable 148079
Build 223411: arc lint + arc unit

Event Timeline

gw created this revision.Dec 17 2019, 9:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2019, 9:16 PM
phab-bot requested review of this revision.Dec 17 2019, 9:16 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

Code analysis found 1 defect in the diff 209362:

  • 1 defect found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -s -p gfx/webrender_bindings/WebRenderAPI.cpp (C/C++)

For your convenience, here is a patch that fixes all the source-test-clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:

Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

kvark accepted this revision.Dec 17 2019, 9:48 PM
This revision is now accepted and ready to land.Dec 17 2019, 9:48 PM
gw updated this revision to Diff 209418.Dec 17 2019, 9:51 PM

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:

Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.