Page MenuHomePhabricator
Differential D57248

Bug 1604062 - Use less Au in font code. r=heycam
ClosedPublic
Actions

Authored by emilio on Dec 15 2019, 7:46 PM.

Details

Reviewers
heycam
boris
Commits
rMOZILLACENTRALb2da3109db2c: Bug 1604062 - Use less Au in font code. r=boris
Bugzilla Bug ID
1604062
Summary

Font code is the only thing that was using Au in the style system without
interfacing with Gecko, and there was no real reason for it to do so.

This slightly simplifies the code.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Dec 15 2019, 7:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2019, 7:46 PM
Harbormaster completed remote builds in B146541: Diff 208041.Dec 15 2019, 7:46 PM
phab-bot requested review of this revision.Dec 15 2019, 7:46 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
emilio added reviewers: boris, Restricted Project.Dec 15 2019, 9:11 PM
emilio updated this revision to Diff 208054.Dec 15 2019, 9:33 PM

Servo build fixes

Harbormaster completed remote builds in B146553: Diff 208054.Dec 15 2019, 9:33 PM
boris accepted this revision.EditedDec 16 2019, 12:59 PM
boris removed a reviewer: Restricted Project.

Made a quick review and it seems we have less conversion after replacing Au with Length (maybe).

This revision is now accepted and ready to land.Dec 16 2019, 12:59 PM
emilio added a comment.Dec 16 2019, 1:22 PM

Made a quick review and it seems we have less conversion after replacing Au with Length (maybe).

Yeah, that was also part of the intention.

Closed by commit rMOZILLACENTRALb2da3109db2c: Bug 1604062 - Use less Au in font code. r=boris (authored by emilio). · Explain WhyDec 16 2019, 1:27 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALb2da3109db2c: Bug 1604062 - Use less Au in font code. r=boris.

Revision Contents
Changeset List

PathSize
servo/
components/
style/
10 lines
gecko/
10 lines
13 lines
2 lines
properties/
3 lines
2 lines
servo/
4 lines
values/
computed/
8 lines
2 lines
specified/
40 lines
5 lines
39 lines
13 lines

Diff 208307

View Options

servo/components/style/font_metrics.rs

Loading...
View Options

servo/components/style/gecko/media_queries.rs

Loading...
View Options

servo/components/style/gecko/wrapper.rs

Loading...
View Options

servo/components/style/matching.rs

Loading...
View Options

servo/components/style/properties/cascade.rs

Loading...
View Options

servo/components/style/properties/gecko.mako.rs

Loading...
View Options

servo/components/style/servo/media_queries.rs

Loading...
View Options

servo/components/style/values/computed/font.rs

Loading...
View Options

servo/components/style/values/computed/length.rs

Loading...
View Options

servo/components/style/values/specified/font.rs

Loading...
View Options

servo/components/style/values/specified/gecko.rs

Loading...
View Options

servo/components/style/values/specified/length.rs

Loading...
View Options

servo/components/style/values/specified/text.rs

Loading...
Privacy · Cookies · Legal