Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Code analysis found 34 defects in the diff 208038:
- 34 defects found by clang-format
You can run this analysis locally with:
- ./mach clang-format -s -p gfx/2d/Factory.cpp (C/C++)
For your convenience, here is a patch that fixes all the source-test-clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
| gfx/2d/Factory.cpp | ||
|---|---|---|
| 206 ↗ | (On Diff #208038) | There's no need to use dlsym here since FT_GlyphSlot_Embolden is ancient and dates back to FreeType 2.1, which is way older than the cutoff we set for FT versions anyway... |
| gfx/2d/Factory.cpp | ||
|---|---|---|
| 206 ↗ | (On Diff #208038) | Fair enough - it was just copied from what we have in SkFontHost_cairo.cpp, but let's drop it. |