- Fix crash due to shift left causing overflow (debug only)
- Remove rounding of scrolling offsets and snap to view space instead of
world space
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable. - Build Status
Buildable 149483 Build 225618: arc lint + arc unit
Event Timeline
| gfx/layers/apz/src/APZCTreeManager.cpp | ||
|---|---|---|
| 731 | \o/ | |
| gfx/wr/webrender/src/picture.rs | ||
| 3250 | How does this produce a different result? | |
| gfx/wr/webrender/src/spatial_node.rs | ||
| 439 | I expect this will break snapping in non-deterministic ways. We used the content transform to snap everything during scene building, so the fractional offset cannot change. This is also inconsistent with how update_transform snaps the offset. That said, I understand the bug now. I think you should apply the scale to the relative offset (that is to say, added_offset), snap, and then add that to the current transform's offset. | |
Comment Actions
Also, can you post the try results for Linux and Windows? If there is any fuzz necessary, I'd like to review that as well. I've made plenty of mistakes fuzzing real issues this year that I had to painstakingly figure out later :(.
| gfx/wr/webrender/src/spatial_node.rs | ||
|---|---|---|
| 439 | Addendum: This is also inconsistent with how update_transform snaps the offset *for ReferenceFrames* around line 353. | |
Comment Actions
Sorry, too many distractions made this take way too long.
Try results here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54d83f11d4b57a98c81094ef1456235b2a7e6d45