Details

Reviewers

xidorn
smaug

Commits

rMOZILLACENTRAL27fdce12f0c5: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug
rMOZILLACENTRALd23f209ada8b: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug

Bugzilla Bug ID

1603455

Summary

It's been enabled since Firefox 64.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Dec 12 2019, 3:19 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2019, 3:19 PM

Harbormaster completed remote builds in B145691: Diff 206840.Dec 12 2019, 3:19 PM

phab-bot requested review of this revision.Dec 12 2019, 3:20 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Herald added a subscriber: jya. · View Herald TranscriptDec 12 2019, 3:20 PM

Don't remove LenientSetter.

dom/webidl/DocumentOrShadowRoot.webidl
31	Oh, this looks wrong. Per spec there should be LenientSetter.

emilio updated this revision to Diff 206843.Dec 12 2019, 3:29 PM

emilio edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B145692: Diff 206843.Dec 12 2019, 3:29 PM

emilio marked an inline comment as done.Dec 12 2019, 3:30 PM

emilio added inline comments.

dom/webidl/DocumentOrShadowRoot.webidl
31	Whoops, great catch, fixed. A test caught this too, fwiw. A bit weird that `mozFullScreenElement` isn't a `LenientSetter` as well but...

xidorn accepted this revision as: xidorn.Dec 12 2019, 7:34 PM

xidorn removed a reviewer: Restricted Project.

This revision is now accepted and ready to land.Dec 12 2019, 7:34 PM

emilio removed a reviewer: webidl.Dec 12 2019, 7:55 PM

emilio removed a parent revision: D56950: Bug 1603455 - Remove layout.css.xul-tree-pseudos.content.enabled. r=#style.

Closed by commit rMOZILLACENTRALd23f209ada8b: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug (authored by emilio). · Explain WhyDec 12 2019, 8:00 PM

This revision was automatically updated to reflect the committed changes.

emilio marked an inline comment as done.

emilio added a commit: rMOZILLACENTRALd23f209ada8b: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug.

noemi_erli reopened this revision.Dec 12 2019, 9:54 PM

This revision is now accepted and ready to land.Dec 12 2019, 9:54 PM

noemi_erli added a reverting change: rMOZILLACENTRALa1516b9539d1: Backed out changeset d23f209ada8b (bug 1603455) for causing failures in….Dec 12 2019, 9:54 PM

keep api-enabled check, which is a different pref

Harbormaster completed remote builds in B146149: Diff 207530.Dec 13 2019, 1:27 PM

Closed by commit rMOZILLACENTRAL27fdce12f0c5: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug (authored by emilio). · Explain WhyDec 13 2019, 1:31 PM

This revision was automatically updated to reflect the committed changes.

emilio added a commit: rMOZILLACENTRAL27fdce12f0c5: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug.

Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,#style!,#webidl!
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 207539

browser/base/content/test/static/browser_parsable_css.js

dom/base/Document.h

dom/base/Document.cpp

dom/base/test/test_youtube_flash_embed.html

dom/events/EventListenerManager.cpp

dom/events/test/pointerevents/test_trigger_fullscreen_by_pointer_events.html

dom/html/test/browser_fullscreen-newtab.js

dom/html/test/file_fullscreen-unprefix-disabled-inner.html

dom/html/test/file_fullscreen-unprefix-disabled.html

dom/html/test/mochitest.ini

dom/html/test/test_fullscreen-api-race.html

dom/html/test/test_fullscreen-api.html

dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html

dom/plugins/test/mochitest/test_bug1028200-1.html

dom/plugins/test/mochitest/test_bug1028200-2.html

dom/plugins/test/mochitest/test_bug1028200-3.html

dom/plugins/test/mochitest/test_bug1028200-4.html

dom/plugins/test/mochitest/test_bug1028200-5.html

dom/plugins/test/mochitest/test_bug1028200-6.html

dom/plugins/test/mochitest/test_bug1028200-7.html

dom/tests/mochitest/pointerlock/test_pointerlock-api.html

dom/webidl/Document.webidl

dom/webidl/DocumentOrShadowRoot.webidl

dom/webidl/Element.webidl

modules/libpref/init/StaticPrefList.yaml

servo/components/style/gecko/non_ts_pseudo_class_list.rs

servo/components/style/gecko/selector_parser.rs

servo/components/style/gecko/wrapper.rs

testing/web-platform/meta/fullscreen/dir.ini

testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html.ini

Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,#style!,#webidl!ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 207539

browser/base/content/test/static/browser_parsable_css.js

dom/base/Document.h

dom/base/Document.cpp

dom/base/test/test_youtube_flash_embed.html

dom/events/EventListenerManager.cpp

dom/events/test/pointerevents/test_trigger_fullscreen_by_pointer_events.html

dom/html/test/browser_fullscreen-newtab.js

dom/html/test/file_fullscreen-unprefix-disabled-inner.html

dom/html/test/file_fullscreen-unprefix-disabled.html

dom/html/test/mochitest.ini

dom/html/test/test_fullscreen-api-race.html

dom/html/test/test_fullscreen-api.html

dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html

dom/plugins/test/mochitest/test_bug1028200-1.html

dom/plugins/test/mochitest/test_bug1028200-2.html

dom/plugins/test/mochitest/test_bug1028200-3.html

dom/plugins/test/mochitest/test_bug1028200-4.html

dom/plugins/test/mochitest/test_bug1028200-5.html

dom/plugins/test/mochitest/test_bug1028200-6.html

dom/plugins/test/mochitest/test_bug1028200-7.html

dom/tests/mochitest/pointerlock/test_pointerlock-api.html

dom/webidl/Document.webidl

dom/webidl/DocumentOrShadowRoot.webidl

dom/webidl/Element.webidl

modules/libpref/init/StaticPrefList.yaml

servo/components/style/gecko/non_ts_pseudo_class_list.rs

servo/components/style/gecko/selector_parser.rs

servo/components/style/gecko/wrapper.rs

testing/web-platform/meta/fullscreen/__dir__.ini

testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html.ini

Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,#style!,#webidl!
ClosedPublic
Actions

Revision Contents
Changeset List

testing/web-platform/meta/fullscreen/dir.ini