Page MenuHomePhabricator
Differential D56732

Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen
ClosedPublic
Actions

Authored by emilio on Dec 11 2019, 1:47 PM.

Details

Reviewers
hsivonen
Commits
rMOZILLACENTRAL34c6d0d056ce: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen…
rMOZILLACENTRAL7e9e38f8bd84: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen…
rMOZILLACENTRAL79e508e5f428: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen
Bugzilla Bug ID
1602843
Summary

This avoids the mutation due to the different serialization in some cases.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Dec 11 2019, 1:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2019, 1:47 PM
Harbormaster completed remote builds in B145118: Diff 206049.Dec 11 2019, 1:47 PM
phab-bot requested review of this revision.Dec 11 2019, 1:47 PM
phab-bot changed the visibility from "Custom Policy" to "Custom Policy".
phab-bot changed the edit policy from "Custom Policy" to "Custom Policy".
phab-bot added a project: Restricted Project.
phab-bot added subscribers: hsivonen, freddyb, emilio.
emilio updated this revision to Diff 206082.Dec 11 2019, 2:44 PM
Harbormaster completed remote builds in B145142: Diff 206082.Dec 11 2019, 2:44 PM
phab-bot added subscribers: masayuki, m_kato.Dec 11 2019, 2:50 PM
emilio updated this revision to Diff 206155.Dec 11 2019, 4:39 PM
emilio retitled this revision from Bug 1602843 - WIP: Preserve rule input exactly after sanitization. to Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen.
emilio edited the summary of this revision. (Show Details)
emilio added a reviewer: hsivonen.
Harbormaster completed remote builds in B145199: Diff 206155.Dec 11 2019, 4:39 PM
hsivonen accepted this revision.Dec 12 2019, 9:33 AM

Thanks!

This revision is now accepted and ready to land.Dec 12 2019, 9:33 AM
phab-bot added a subscriber: tjr.Dec 12 2019, 1:57 PM
Closed by commit rMOZILLACENTRAL79e508e5f428: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen (authored by emilio). · Explain WhyDec 13 2019, 1:53 AM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRAL79e508e5f428: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen.
phab-bot changed the visibility from "Custom Policy" to "Custom Policy".Dec 13 2019, 10:02 AM
phab-bot changed the edit policy from "Custom Policy" to "Custom Policy".
phab-bot added a project: Restricted Project.
phab-bot added a subscriber: jcristau.Dec 16 2019, 12:14 PM
phab-bot added a subscriber: RyanVM.Dec 16 2019, 3:51 PM
phab-bot added subscribers: noemi_erli, aryx.Dec 16 2019, 4:42 PM
emilio added a commit: rMOZILLACENTRAL7e9e38f8bd84: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen….Dec 16 2019, 5:33 PM
phab-bot added a subscriber: bogdan_maris.Dec 17 2019, 9:07 AM
emilio added a commit: rMOZILLACENTRAL34c6d0d056ce: Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen….Dec 20 2019, 7:47 PM
phab-bot added a subscriber: Wolfbeast.Jan 7 2020, 4:52 PM
phab-bot added a subscriber: danibodea.Jan 29 2020, 12:22 PM
phab-bot removed a subscriber: aryx.Mar 6 2020, 10:52 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jun 5 2020, 7:32 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed projects: Restricted Project, Restricted Project, Restricted Project.

Revision Contents
Changeset List

PathSize
dom/
base/
9 lines
105 lines
layout/
style/
12 lines
test/
gtest/
3 lines
servo/
components/
style/
stylesheets/
1 line
90 lines
ports/
geckolib/
28 lines
1 line

Diff 207248

View Options

dom/base/nsTreeSanitizer.h

Loading...
View Options

dom/base/nsTreeSanitizer.cpp

Loading...
View Options

layout/style/StyleSheet.cpp

Loading...
View Options

layout/style/test/gtest/StyloParsingBench.cpp

Loading...
View Options

servo/components/style/stylesheets/mod.rs

Loading...
View Options

servo/components/style/stylesheets/stylesheet.rs

Loading...
View Options

servo/ports/geckolib/glue.rs

Loading...
View Options

servo/ports/geckolib/stylesheet_loader.rs

Loading...
Privacy · Cookies · Legal