Differential D56406

Bug 1602458 - Avoid reallocating opacity bindings and tiles hash maps in TileCacheInstance. r=gw
ClosedPublic
Actions

Authored by nical on Dec 9 2019, 5:08 PM.

Details

Reviewers

Commits

rMOZILLACENTRAL7f28f9e9ec25: Bug 1602458 - Avoid reallocating opacity bindings and tiles hash maps in…

Bugzilla Bug ID

1602458

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nical created this revision.Dec 9 2019, 5:08 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 5:08 PM

Harbormaster completed remote builds in B144269: Diff 204861.Dec 9 2019, 5:08 PM

phab-bot requested review of this revision.Dec 9 2019, 5:08 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

nical added a child revision: D56407: Bug 1602458 - Avoid reallocaitng spatial nodes hash map. r=gw.Dec 9 2019, 5:08 PM

Although unlikely, this seems like it could _potentially_ leak memory - if swapping between scenes where the hash keys are regularly different (e.g. the tile x/y offsets)? Probably not an issue in practice, I think, but maybe we should still clear / trim the recycled hash map?

This revision is now accepted and ready to land.Dec 10 2019, 1:58 AM

Revision updated.

Harbormaster completed remote builds in B144709: Diff 205479.Dec 10 2019, 4:18 PM

Revision updated.

Harbormaster completed remote builds in B145533: Diff 206624.Dec 12 2019, 9:08 AM

Closed by commit rMOZILLACENTRAL7f28f9e9ec25: Bug 1602458 - Avoid reallocating opacity bindings and tiles hash maps in… (authored by nical). · Explain WhyDec 12 2019, 9:19 AM

This revision was automatically updated to reflect the committed changes.

nical added a commit: rMOZILLACENTRAL7f28f9e9ec25: Bug 1602458 - Avoid reallocating opacity bindings and tiles hash maps in….