Details
- Reviewers
emilio - Commits
- rMOZILLACENTRAL9039c530cf10: Bug 1601990 : convert NS_STYLE_POINTER_EVENTS_* to an enum class in…
- Bugzilla Bug ID
- 1601990
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable. - Build Status
Buildable 145970 Build 219886: arc lint + arc unit
Event Timeline
The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.
If you see a problem in this automated review, please report it here.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=248ff1227c0fbba45c8d0ea804db2c721d7e6300
error[E0599]: no variant or associated item named `Visiblepainted` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error[E0599]: no variant or associated item named `Visiblefill` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error[E0599]: no variant or associated item named `Visiblestroke` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error[E0599]: no variant or associated item named `Visiblepainted` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error[E0599]: no variant or associated item named `Visiblefill` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error[E0599]: no variant or associated item named `Visiblestroke` found for type `gecko_bindings::structs::root::mozilla::StylePointerEvents` in the current scope
error: Could not compile `style`.
1584045Intermittent Win 2012 [taskcluster:error] Aborting task... | failed to execute compile | error: Could not compile `style`.
make[1]: *** [force-cargo-test-run] Error 101
make: *** [toolkit/library/rust/rusttests] Error 2
Return code: 2
'mach build -v pre-export export recurse_rusttests' did not run successfully. Please check log for errors.
Running post_fatal callback...| layout/style/nsStyleConsts.h | ||
|---|---|---|
| 573 | Well, you need to rename these to match the css keyword. The keyword is visiblepainted, so the enum is Visiblepainted, not VisiblePainted (which would be the case for visible-painted, for example). | |
The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.
If you see a problem in this automated review, please report it here.
| layout/style/nsStyleConsts.h | ||
|---|---|---|
| 573 | Instead, this should be Visiblepainted. | |
| 574 | This should be Visiblefill. | |
| 575 | And this Visiblestroke. | |
| servo/components/style/properties/longhands/inherited_ui.mako.rs | ||
| 27 | No, you need to change the name of the enum variant, not this. This changes the values parsed, which is wrong. | |
There are usages you've missed in nsMenuPopupFrame.cpp: https://searchfox.org/mozilla-central/search?q=NS_STYLE_POINTER_EVENTS_NONE&case=false®exp=false&path=
The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.
If you see a problem in this automated review, please report it here.
/builds/worker/workspace/build/src/layout/xul/nsMenuPopupFrame.cpp:288:75: error: expected unqualified-id
/builds/worker/workspace/build/src/layout/xul/nsMenuPopupFrame.cpp:480:73: error: expected unqualified-id
/builds/worker/workspace/build/src/layout/xul/nsMenuPopupFrame.cpp:482:63: error: expected unqualified-id
make[4]: *** [Unified_cpp_layout_xul0.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [layout/xul/target-objects] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [compile] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2
1515621Intermittent make: *** [build] Error 2 due to broken artifact builds on Android 7.0 (missing app-withoutGeckoBinaries-debug.apk)
1442211Intermittent make: *** [build] Error 2 after Starting sccache server... error: Timed out waiting for server startup
1570503Intermittent make: *** [build] Error 2 after [js/src/jsapi-tests/target] Error 2
1470945Intermittent make: *** [build] Error 2 after error reading compile response from server
Return code: 2
'mach build -v' did not run successfully. Please check log for errors.
1584213Intermittent 'mach build -v' did not run successfully. Please check log for errors. after [client.mk:125: build] Error 2
1598844Intermittent 'mach build -v' did not run successfully. Please check log for errors. after KeyError: u'package-generated-sources'
Show / Hide more
Running post_fatal callback...
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #@emilio Here is the job - https://treeherder.mozilla.org/#/jobs?repo=try&revision=b65f3d43b4a44d1dd223fc04da3d912349446487&selectedJob=280783932
Thanks. This is an X11 header which has a macro called None defined to be 0. From the log:
[task 2019-12-12T01:57:24.903Z] 01:57:24 INFO - /usr/include/X11/X.h:115:30: note: expanded from macro 'None'
[task 2019-12-12T01:57:24.903Z] 01:57:24 INFO - #define None 0L /* universal null resource or null atom */
So in practice that line ends up being:
StyleUI()->GetEffectivePointerEvents(this) == StylePointerEvents::0L;
Which fails to compile.
I would add:
#include "X11UndefineNone.h"
Which should, well, undefine None, and make the code build :)
@emilio Thanks for investigating and telling me the solution
Everything is green : - https://treeherder.mozilla.org/#/jobs?repo=try&revision=046903c7270e6a7bad996ac23aff20a1d1aedc17
I will check in this :)