Details
- Reviewers
emilio - Commits
- rMOZILLACENTRALa78b1f43fcab: Bug 1601856 : convert NS_STYLE_VISIBILITY_* to an enum class in nsStyleConsts.h…
- Bugzilla Bug ID
- 1601856
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Code analysis found 1 defect in the diff 203822:
- 1 defect found by clang-tidy
You can run this analysis locally with:
- ./mach static-analysis check layout/xul/nsDeckFrame.cpp (C/C++)
If you see a problem in this automated review, please report it here.
| layout/xul/nsDeckFrame.cpp | ||
|---|---|---|
| 141–142 | Warning: Statement should be inside braces [clang-tidy: readability-braces-around-statements] | |
Looks great, thanks so much for this!
| layout/style/nsStyleStruct.cpp | ||
|---|---|---|
| 3167–3168 | If while you're here you want to remove the redundant parenthesis that'd be great :) | |
| layout/style/nsStyleStruct.h | ||
| 1278 | Same here. | |
| 1282–1283 | Same here. All parens in these two lines are useless and just noise. | |
| layout/tables/nsTableRowFrame.cpp | ||
| 1213 | In all the conditions that look like this you could also remove the parens without loss in readability IMO. | |
| layout/xul/nsDeckFrame.cpp | ||
| 141–142 | If you want to fix the reviewbot nit it'd be awesome too :) | |
Made all the changes
Green - https://treeherder.mozilla.org/#/jobs?repo=try&revision=47a9f9c40e330083db8815a5db3838840d0e43ab
Good to go from my side :)