Page MenuHomePhabricator
Differential D55591

Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam
ClosedPublic
Actions

Authored by emilio on Dec 3 2019, 1:36 AM.

Details

Reviewers
heycam
Commits
rMOZILLACENTRALf41a72eb9c5f: Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam…
rMOZILLACENTRALdc7693501534: Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam
Bugzilla Bug ID
1600773
Summary

I was going to send a test for :focus via wpt, but then realized it was
probably not spec-compliant with the new rules people want to follow for
:focus, so I filed https://github.com/w3c/csswg-drafts/issues/4555 instead.

Testing :hover / :active via wpt looked quite a bit of a hassle.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Dec 3 2019, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2019, 1:36 AM
Harbormaster completed remote builds in B141734: Diff 201360.Dec 3 2019, 1:36 AM
phab-bot requested review of this revision.Dec 3 2019, 1:36 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
bgrins added a subscriber: bgrins.Dec 3 2019, 3:51 AM
heycam accepted this revision.Dec 9 2019, 4:03 AM
heycam added inline comments.
servo/components/style/dom.rs
854

Nit: drop one blank line?

This revision is now accepted and ready to land.Dec 9 2019, 4:03 AM
emilio updated this revision to Diff 204727.Dec 9 2019, 1:40 PM

Remove extra newline

Harbormaster completed remote builds in B144178: Diff 204727.Dec 9 2019, 1:40 PM
Closed by commit rMOZILLACENTRALdc7693501534: Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam (authored by emilio). · Explain WhyDec 9 2019, 1:44 PM
This revision was automatically updated to reflect the committed changes.
emilio added a commit: rMOZILLACENTRALdc7693501534: Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam.
emilio added a commit: rMOZILLACENTRALf41a72eb9c5f: Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam….Dec 10 2019, 4:10 PM

Revision Contents
Changeset List

PathSize
layout/
style/
test/
1 line
52 lines
servo/
components/
style/
36 lines
6 lines
15 lines

Diff 204728

View Options

layout/style/test/mochitest.ini

Loading...
View Options

layout/style/test/test_hover_on_part.html

Loading...
View Options

servo/components/style/dom.rs

Loading...
View Options

servo/components/style/rule_collector.rs

Loading...
View Options

servo/components/style/stylist.rs

Loading...
Privacy · Cookies · Legal