Page MenuHomePhabricator

Make sticky legend reftest not depend on groove border antialising.
ClosedPublic

Authored by emilio on Sep 4 2018, 12:37 PM.

Details

Summary

This reftest fails with my changes from
https://github.com/servo/webrender/pull/3010. I tried to debug locally but it
passes here.

The reason it fails is because WebRender does distance AA between the segments
of a ridge / groove border, and there's a subpixel difference so we get the AA
slightly different in the test.

Gecko on the other hand represents these borders as different composed solid
segments, so it can't have this problem, since it doesn't do AA across the
segments.

We may want to change that, but it's not clear to me it's wanted, since rounded
corners for these look much better on WR, for example.

Rather than fuzzing the test or something like that, make the test not rely on
that, given it's testing the position of the legend.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Sep 4 2018, 12:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2018, 12:37 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 4 2018, 12:37 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
emilio requested review of this revision.Sep 4 2018, 12:37 PM
nical accepted this revision.Sep 4 2018, 2:58 PM
This revision is now accepted and ready to land.Sep 4 2018, 2:58 PM
emilio updated this revision to Diff 12656.Sep 4 2018, 3:17 PM

Turns out the rest was already marked as very fuzzy. So remove the fuzziness
annotation now that the test is reliable.

This revision was automatically updated to reflect the committed changes.