Details

Reviewers

Commits

rMOZILLACENTRALdccb73a9ee2b: Bug 1570442 - Flip upside down recorded frames right side up on non-ANGLE…

Bugzilla Bug ID

Summary

Frames captured by the composition recorder on non-ANGLE configurations were
previously written upside down to disk. We now flip them right side up when
mapping them into memory.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

barret created this revision.Jul 31 2019, 9:51 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2019, 9:51 PM

Harbormaster completed remote builds in B98323: Diff 140382.Jul 31 2019, 9:51 PM

phab-bot requested review of this revision.Jul 31 2019, 9:51 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

barret added a parent revision: D39791: Bug 1566915 - Do not ref count the CompositionRecorder r?mstange.Jul 31 2019, 9:54 PM

Revision updated.

barret edited the summary of this revision. (Show Details)Jul 31 2019, 9:54 PM

Harbormaster completed remote builds in B98326: Diff 140386.Jul 31 2019, 9:54 PM

kvark requested changes to this revision.Aug 1 2019, 8:19 PM

kvark added inline comments.

gfx/wr/webrender/src/screen_capture.rs
361	What makes macos different here? Do we have similar code in, say, Wrench (that needs to do readback for reftests) that is macOS specific?

This revision now requires changes to proceed.Aug 1 2019, 8:19 PM

Revision updated.

barret retitled this revision from Bug 1570442 - Flip upside down recorded frames right side up on macOS r?kvark to Bug 1570442 - Flip upside down recorded frames right side up on macOS and Linux r?kvark.Aug 6 2019, 3:48 PM

barret edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B100299: Diff 142932.Aug 6 2019, 3:48 PM

So it only needs to be flipped for Angle on Windows?

Instead of trying to re-order the rows here, can we just provide a flag (or just figure this out automatically) in Renderer::scale_screenshot? It currently flips the content for level == 0.

This revision now requires changes to proceed.Aug 6 2019, 6:06 PM

In D40113#1228445, @kvark wrote:

So it only needs to be flipped for Angle on Windows?

Instead of trying to re-order the rows here, can we just provide a flag (or just figure this out automatically) in Renderer::scale_screenshot? It currently flips the content for level == 0.

Renderer::scale_screenshot is only called in the ProfilerScreenshots case where this does not occur.

Revision updated.

Harbormaster completed remote builds in B102552: Diff 145997.Aug 12 2019, 6:17 PM

barret retitled this revision from Bug 1570442 - Flip upside down recorded frames right side up on macOS and Linux r?kvark to Bug 1570442 - Flip upside down recorded frames right side up on non-ANGLE configurations r?kvark.Aug 12 2019, 6:17 PM

barret edited the summary of this revision. (Show Details)

Just one small change. The last one, I promise! :)