Details
- Reviewers
gw - Commits
- rMOZILLACENTRALb5d6ed62cda1: Bug 1178765 - Part 1: Add backdrop-filter WebRender display items r=gw
- Bugzilla Bug ID
- 1178765
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| gfx/webrender_bindings/src/bindings.rs | ||
|---|---|---|
| 2088 | Let's add a link in the comment here to the spec describing what a backdrop root is. | |
| gfx/wr/webrender_api/src/display_item.rs | ||
| 108 | It's not clear to me that we want / need to expose the capture as part of the public API. I haven't read the rest of the patch yet, but it seems like this should be an internal implementation detail? | |
| gfx/wr/webrender_api/src/display_item.rs | ||
|---|---|---|
| 108 | The original reason was because the backdrop capture/filter may need to be in different places in the display list. For example, if an element has opacity applied, it forms a backdrop root. We need to make sure to capture before the backdrop root is pushed, but the filter must be pushed after the opacity stacking context is pushed so the opacity applies to the filtered backdrop. Since I am explicitly pushing a backdrop root stacking context from Gecko and not trying to infer in WebRender, I think I can probably merge capture/filter into a single item or just add it as parameters to stacking context. | |